From: Ophir Bleicher <ophirble@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Ophir Bleicher via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] lazyload: fix typo in comment
Date: Sat, 21 Nov 2026 18:13:00 +0200 [thread overview]
Message-ID: <08E0332F-86DE-4501-8566-895E6ECEEDA5@gmail.com> (raw)
In-Reply-To: <97cb053a-07a2-c840-c8c6-d1455b282580@gmx.de>
Thank you!
> On 21 Nov 2026, at 18:04, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
>
> Hi Ophir,
>
> On Sat, 21 Nov 2026, Ophir Bleicher via GitGitGadget wrote:
>
>> From: Ophir Bleicher <ophirble@gmail.com>
>>
>> Fix a typo on line 11 of compat/win32/lazyload.h, inside a comment.
>> That comment shows an example of function usage, without a closing
>> parentheses:
>>
>> return error("Could not find CreateHardLinkW() function";
>>
>> There isn't any closing ')'.
>
> Yes, this was incorrect, and your fix is much appreciated.
>
> Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> Thank you,
> Johannes
>
>>
>> Signed-off-by: Ophir Bleicher <ophirble@gmail.com>
>> ---
>> lazyload: fix typo in comment
>>
>> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2497%2FOphirBleicher%2Ffix-typo-lazyload-v1
>> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2497/OphirBleicher/fix-typo-lazyload-v1
>> Pull-Request: https://github.com/git/git/pull/2497
>>
>> compat/win32/lazyload.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/compat/win32/lazyload.h b/compat/win32/lazyload.h
>> index f2bb96c89c..d348a89f9b 100644
>> --- a/compat/win32/lazyload.h
>> +++ b/compat/win32/lazyload.h
>> @@ -8,7 +8,7 @@
>> * LPCWSTR, LPCWSTR, LPSECURITY_ATTRIBUTES);
>> *
>> * if (!INIT_PROC_ADDR(CreateHardLinkW))
>> - * return error("Could not find CreateHardLinkW() function";
>> + * return error("Could not find CreateHardLinkW() function");
>> *
>> * if (!CreateHardLinkW(source, target, NULL))
>> * return error("could not create hardlink from %S to %S",
>>
>> base-commit: f7de81456940dd6f3274e461149bba12965de609
>> --
>> gitgitgadget
>>
>>
prev parent reply other threads:[~2026-11-21 16:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 15:44 [PATCH] lazyload: fix typo in comment Ophir Bleicher via GitGitGadget
2026-11-21 16:04 ` Johannes Schindelin
2026-11-21 16:13 ` Ophir Bleicher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08E0332F-86DE-4501-8566-895E6ECEEDA5@gmail.com \
--to=ophirble@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox