From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
To: "Wolfgang Müller" <wolf@oriole.systems>, git@vger.kernel.org
Subject: Re: [RFC PATCH] builtin/shortlog: explicitly set hash algo when there is no repo
Date: Tue, 15 Oct 2024 11:47:13 +0200 [thread overview]
Message-ID: <08bdd8dd-06d8-47a6-8b44-fa6add14d60a@app.fastmail.com> (raw)
In-Reply-To: <r4btv3hmwv6haflwhmjbjshova4wnth5mkbknsuuqcvose5lix@bvy5e6gxnit6>
On Tue, Oct 15, 2024, at 11:33, Wolfgang Müller wrote:
> > […]
>
> Was this topic maybe missed? It's not a critical fix but would solve a
> segfault that is pretty easy for a user to trigger.
I can confirm that this gives me a segfault:
```
# Directory which is not tracked
cd ~
git shortlog --author=Kristoffer
```
Maybe a few things could make the change more ready to be included:
1. A regression test for that segfault
2. A quickfix (which you indicate below the three-dash/hyphens) can be
documented in the comment above the code with a `NEEDSWORK`
--
Kristoffer Haugsbakk
next prev parent reply other threads:[~2024-10-15 9:47 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 18:34 [RFC PATCH] builtin/shortlog: explicitly set hash algo when there is no repo Wolfgang Müller
2024-10-15 9:33 ` Wolfgang Müller
2024-10-15 9:47 ` Kristoffer Haugsbakk [this message]
2024-10-15 19:54 ` Taylor Blau
2024-10-15 23:28 ` Taylor Blau
2024-10-16 8:15 ` Wolfgang Müller
2024-10-16 18:28 ` Taylor Blau
2024-10-15 11:48 ` [RFC PATCH v2] " Wolfgang Müller
2024-10-15 17:20 ` Eric Sunshine
2024-10-15 17:51 ` Wolfgang Müller
2024-10-16 5:32 ` Patrick Steinhardt
2024-10-16 8:47 ` Wolfgang Müller
2024-10-16 8:57 ` Patrick Steinhardt
2024-10-16 9:07 ` Wolfgang Müller
2024-10-16 18:52 ` Taylor Blau
2024-10-16 19:01 ` Wolfgang Müller
2024-10-17 5:04 ` Patrick Steinhardt
2024-10-16 9:48 ` Wolfgang Müller
2024-10-16 19:01 ` Taylor Blau
2024-10-16 19:14 ` Wolfgang Müller
2024-10-16 18:21 ` [PATCH v3 0/2] " Wolfgang Müller
2024-10-16 18:21 ` [PATCH v3 1/2] " Wolfgang Müller
2024-10-16 19:22 ` Taylor Blau
2024-10-16 19:37 ` Wolfgang Müller
2024-10-17 11:58 ` Patrick Steinhardt
2024-10-17 12:09 ` Wolfgang Müller
2024-10-17 12:11 ` Patrick Steinhardt
2024-10-16 18:21 ` [PATCH v3 2/2] shortlog: Test reading a log from a SHA256 repo in a non-git directory Wolfgang Müller
2024-10-16 19:25 ` Taylor Blau
2024-10-16 19:35 ` Wolfgang Müller
2024-10-16 19:45 ` Taylor Blau
2024-10-16 19:32 ` [PATCH v3 0/2] builtin/shortlog: explicitly set hash algo when there is no repo Taylor Blau
2024-10-16 19:38 ` Wolfgang Müller
2024-10-17 9:35 ` [PATCH v4] " Wolfgang Müller
2024-10-17 20:10 ` Taylor Blau
2024-10-17 22:02 ` Wolfgang Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08bdd8dd-06d8-47a6-8b44-fa6add14d60a@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail.com \
--cc=git@vger.kernel.org \
--cc=wolf@oriole.systems \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).