From: Jeff Hostetler <git@jeffhostetler.com>
To: Jeff King <peff@peff.net>, Thomas Gummerer <t.gummerer@gmail.com>
Cc: git@vger.kernel.org, gitster@pobox.com,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v3 0/2] read-cache: call verify_hdr() in a background thread
Date: Fri, 31 Mar 2017 09:23:39 -0400 [thread overview]
Message-ID: <094f16d2-e1d9-1478-df6a-4f24f17e184e@jeffhostetler.com> (raw)
In-Reply-To: <20170330203916.ckp62syupioo3hxc@sigill.intra.peff.net>
On 3/30/2017 4:39 PM, Jeff King wrote:
> On Thu, Mar 30, 2017 at 09:06:48PM +0100, Thomas Gummerer wrote:
>
>>> Yeah, I think that would be fine. You _could_ write a t/perf test and
>>> then use your 400MB monstrosity as GIT_PERF_LARGE_REPO. But given that
>>> most people don't have such a thing, there's not much value over you
>>> just showing off the perf improvement in the commit message.
>>
>> Sorry if this was already discussed, but we already do have a perf
>> test for the index (p0002), and a corresponding helper program which
>> just does read_cache() and discard_cache(). Maybe we could re-use
>> that and add a second test running the same using the new config?
>
> Oh, indeed. Yes, I would think the results of p0002 would probably show
> off Jeff's improvements.
>
> -Peff
>
Let me re-roll it with Junio's cleanup, update fsck to force it on,
and look at using p0002.
Thanks,
Jeff
prev parent reply other threads:[~2017-03-31 13:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 19:07 [PATCH v3 0/2] read-cache: call verify_hdr() in a background thread git
2017-03-28 19:07 ` [PATCH v3 1/2] read-cache: core.checksumindex git
2017-03-28 19:07 ` [PATCH v3 2/2] test-core-checksum-index: core.checksumindex test helper git
2017-03-28 19:16 ` [PATCH v3 0/2] read-cache: call verify_hdr() in a background thread Jeff King
2017-03-28 19:50 ` Jeff Hostetler
2017-03-28 19:56 ` Jeff King
2017-03-30 19:49 ` Junio C Hamano
2017-03-30 19:58 ` Jeff King
2017-03-30 20:44 ` Junio C Hamano
2017-03-31 13:20 ` Jeff Hostetler
2017-03-30 20:06 ` Thomas Gummerer
2017-03-30 20:39 ` Jeff King
2017-03-31 13:23 ` Jeff Hostetler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=094f16d2-e1d9-1478-df6a-4f24f17e184e@jeffhostetler.com \
--to=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=peff@peff.net \
--cc=t.gummerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).