* Re: (patch) calloc->xaclloc in read-cache.c
@ 2006-05-09 16:14 iler.ml
2006-05-09 13:26 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: iler.ml @ 2006-05-09 16:14 UTC (permalink / raw)
To: git
How about this.
--- read-cache.c.000 2006-05-09 15:27:56.000000000 +0000
+++ read-cache.c 2006-05-09 15:28:10.000000000 +0000
@@ -552,7 +552,7 @@
active_nr = ntohl(hdr->hdr_entries);
active_alloc = alloc_nr(active_nr);
- active_cache = calloc(active_alloc, sizeof(struct cache_entry *));
+ active_cache = xcalloc(active_alloc, sizeof(struct cache_entry *));
offset = sizeof(*hdr);
for (i = 0; i < active_nr; i++) {
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: (patch) calloc->xaclloc in read-cache.c
2006-05-09 16:14 (patch) calloc->xaclloc in read-cache.c iler.ml
@ 2006-05-09 13:26 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2006-05-09 13:26 UTC (permalink / raw)
To: iler.ml; +Cc: git
iler.ml@gmail.com writes:
> How about this.
Looks good, thanks. If you needed some MUA trick that other
people might benefit from please feel free to send a patch to
Documentation/SubmittingPatches "MUA specific hints" section.
Except "Subject: [PATCH] blah", commit log message (in this case
what you would have on the Subject line is to the point and you
would not need any extra log message), "Signed-off-by: whom",
and perhaps "---\n". Material that you do not want to have in
the final commit message, like "How about this" and diffstat if
you have one, would come after the "---\n" line.
Your message formatted in the preferred way becomes like this:
Subject: [PATCH] read-cache.c: use xcalloc() not calloc()
Elsewhere we use xcalloc(); we should consistently do so.
Signed-off-by: Yakov Lerner <iler.ml@gmail.com>
---
* How about this?
read-cache.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--- read-cache.c.000 2006-05-09 15:27:56.000000000 +0000
+++ read-cache.c 2006-05-09 15:28:10.000000000 +0000
@@ -552,7 +552,7 @@
active_nr = ntohl(hdr->hdr_entries);
...
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-05-09 13:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-05-09 16:14 (patch) calloc->xaclloc in read-cache.c iler.ml
2006-05-09 13:26 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).