From: <rsbecker@nexbridge.com>
To: "'Doron Behar'" <doron.behar@gmail.com>, <git@vger.kernel.org>
Subject: RE: Re: Remove your ZSH completion in favor of the completion script distributed and maintained by ZSH
Date: Sun, 7 Jul 2024 11:21:54 -0400 [thread overview]
Message-ID: <0a3501dad081$69a5c0c0$3cf14240$@nexbridge.com> (raw)
In-Reply-To: <e4ylt2rihvm2uc22irsxbeid57ijblioekit3o4xpufflrqwal@5t67kr2a5ahq>
On Sunday, July 7, 2024 10:47 AM, Doron Behar wrote:
>They don't perform any version checks as far as I can see in their implementation.
>
>Almost all commands that the ZSH team maintains completions for, don't perform
>version checks and the maintainers of the commands themselves don't bother
>taking responsibility for that and usually users don't complain. If a ZSH user notices
>a new command or new option missing from such a completion function, they can
>submit a patch to the ZSH project, and setup a workaround until there is a new ZSH
>release with their patch included.
>
>Besides the option of living with this potential version mismatch imperfection, you
>could also ask the ZSH team to remove their implementation and start maintain
>their implementation here. However, they might object because not all distributions
>will accommodate to this change in both projects...
>
>I personally think that Git is a stable enough project that the commands and
>options don't deviate enough between the different versions of it, So it'd be easier
>for you and for the distributions if you'd let go of your implementation.
>
>On Sun, Jul 07, 2024 at 04:15:53PM +0200, Andreas Schwab wrote:
>> On Jul 07 2024, Doron Behar wrote:
>>
>> > ZSH completion is almost always distributed with every distribution
>> > of ZSH, so there is no need for the two projects to maintain two
>> > completion functions for the same program :).
>>
>> How do they keep it in sync with the particular version of git
>> installed in the system?
>>
>> --
>> Andreas Schwab, schwab@linux-m68k.org
>> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA
>> AEC1 "And now for something completely different."
>>
There are frequent updates to the git CLI. Freezing ZSH completion at an older version may not be useful. If there is a version compatibility error during install, perhaps take this up with rpm or apt depending on your package manager. I am curious as to why ZSH is overriding git completions.
prev parent reply other threads:[~2024-07-07 15:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-07 11:53 Remove your ZSH completion in favor of the completion script distributed and maintained by ZSH Doron Behar
2024-07-07 14:15 ` Andreas Schwab
2024-07-07 14:47 ` Doron Behar
2024-07-07 14:58 ` brian m. carlson
2024-07-07 18:17 ` Doron Behar
2024-07-07 15:21 ` rsbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0a3501dad081$69a5c0c0$3cf14240$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=doron.behar@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).