From: Derrick Stolee <stolee@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Victoria Dye <vdye@github.com>
Subject: Re: What's cooking in git.git (Oct 2021, #06; Mon, 25)
Date: Tue, 26 Oct 2021 17:54:09 -0400 [thread overview]
Message-ID: <0abd483a-e7f8-9070-0d77-cbedb7f225fc@gmail.com> (raw)
In-Reply-To: <xmqqv91jxyqe.fsf@gitster.g>
On 10/26/2021 5:28 PM, Junio C Hamano wrote:
> Derrick Stolee <stolee@gmail.com> writes:
>
>>> Various operating modes of "git reset" have been made to work
>>> better with the sparse index.
>>>
>>> Needs review.
>>
>> This topic had good review in its first three versions, and the
>> current v4 has had one response that doesn't seem to have actionable
>> changes. Could you re-evaluate if the "needs review" label is still
>> appropriate?
>
> The label indeed does not read well. I know there was a lot of
> dicussions on v3 but in the list traffic, but I do not see anybody
> looked at v4 and said that the issues they pointed out in v3 are now
> covered to their satisfaction. Probably "Needs ack" may have shown
> what I meant better?
That makes sense. I think I've also seen labels such as "Is this ready?"
before, which has a similar call to action.
And I'm sorry that I missed there was something to change in the test.
Thanks,
-Stolee
next prev parent reply other threads:[~2021-10-26 21:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 3:48 What's cooking in git.git (Oct 2021, #06; Mon, 25) Junio C Hamano
2021-10-26 5:25 ` Jeff King
2021-10-27 17:42 ` Junio C Hamano
2021-10-31 18:36 ` Kaartic Sivaraam
2021-11-01 4:04 ` Jeff King
2021-10-26 11:02 ` pre-v2.34.0-rc0 regressions: t7900-maintenance.sh broken due to 'systemd-analyze' (was: What's cooking in git.git (Oct 2021, #06; Mon, 25)) Ævar Arnfjörð Bjarmason
2021-10-26 15:34 ` Ævar Arnfjörð Bjarmason
2021-10-26 18:43 ` Eric Sunshine
2021-11-02 14:24 ` [PATCH] maintenance tests: fix systemd v2.34.0-rc* test regression Ævar Arnfjörð Bjarmason
2021-11-03 5:09 ` Eric Sunshine
2021-11-10 3:52 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2021-11-10 13:36 ` Johannes Schindelin
2021-11-10 16:22 ` Ævar Arnfjörð Bjarmason
2021-11-11 17:45 ` Junio C Hamano
2021-10-26 11:15 ` pre-v2.34.0-rc0 regressions: 'git log' has a noisy iconv() warning (was: What's cooking in git.git (Oct 2021, #06; Mon, 25)) Ævar Arnfjörð Bjarmason
2021-10-27 11:14 ` Jeff King
2021-10-27 18:04 ` pre-v2.34.0-rc0 regressions: 'git log' has a noisy iconv() warning Junio C Hamano
2021-10-28 17:30 ` Jeff King
2021-10-28 19:02 ` Junio C Hamano
2021-10-28 19:17 ` Jeff King
2021-10-26 12:13 ` tb/plug-pack-bitmap-leaks (was: What's cooking in git.git (Oct 2021, #06; Mon, 25)) Ævar Arnfjörð Bjarmason
2021-10-26 21:04 ` Taylor Blau
2021-10-26 12:17 ` jc/branch-copy-doc " Ævar Arnfjörð Bjarmason
2021-10-26 12:42 ` What's cooking in git.git (Oct 2021, #06; Mon, 25) Derrick Stolee
2021-10-26 14:55 ` Ævar Arnfjörð Bjarmason
2021-10-26 17:27 ` Victoria Dye
2021-10-26 21:29 ` Junio C Hamano
2021-10-26 21:28 ` Junio C Hamano
2021-10-26 21:54 ` Derrick Stolee [this message]
2021-10-26 22:21 ` regression in ns/tmp-objdir and ns/batched-fsync Neeraj Singh
2021-10-27 19:17 ` What's cooking in git.git (Oct 2021, #06; Mon, 25) Martin Ågren
2021-10-28 0:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0abd483a-e7f8-9070-0d77-cbedb7f225fc@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).