git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phillip Wood <phillip.wood123@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, Andy Koppe <andy.koppe@gmail.com>
Cc: git@vger.kernel.org, pclouds@gmail.com
Subject: Re: [PATCH] checkout: add config variable checkout.autoDetach
Date: Mon, 13 Nov 2023 15:07:15 +0000	[thread overview]
Message-ID: <0e37ee23-922c-4bbf-82c3-8f44e9216ab0@gmail.com> (raw)
In-Reply-To: <xmqqbkbzo6ba.fsf@gitster.g>



On 12/11/2023 06:04, Junio C Hamano wrote:
> Andy Koppe <andy.koppe@gmail.com> writes:
> 
>> The git-checkout command without pathspecs automatically detaches HEAD
>> when switching to something other than a branch, whereas git-switch
>> requires the --detach option to do so.
>>
>> Add configuration variable checkout.autoDetach to choose the behavior
>> for both: true for automatic detaching, false for requiring --detach.
>>
>> Amend their documentation and tests accordingly.
>>
>> Signed-off-by: Andy Koppe <andy.koppe@gmail.com>
>> ---
> 
> "switch" was meant to be an experimental command to sort out this
> kind of UI ideas, and I think the fact that it requires a more
> explicit "--detach", where experienced users might just say "git
> checkout that-branch^0", has established itself as a more friendly
> and good thing to help new users.  I do not know how others react to
> this kind of proliferation of configuration variables, but I do not
> mind this particular variable existing.

I'm a bit wary of having a config variable that could break scripts 
relying on the current behavior of "git checkout". As far as "git 
switch" goes I don't particularly mind this config variable though I'm 
not sure it is that hard to type "--detach" (especially with tab 
completion) and I do worry that we're making the UI more complex each 
time we add something like this.

Best Wishes

Phillip

  parent reply	other threads:[~2023-11-13 15:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-11 22:42 [PATCH] checkout: add config variable checkout.autoDetach Andy Koppe
2023-11-12  6:04 ` Junio C Hamano
2023-11-12  9:15   ` Andy Koppe
2023-11-13 15:07   ` Phillip Wood [this message]
2023-11-14  0:48     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e37ee23-922c-4bbf-82c3-8f44e9216ab0@gmail.com \
    --to=phillip.wood123@gmail.com \
    --cc=andy.koppe@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pclouds@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).