From: Victoria Dye <vdye@github.com>
To: "Alexander Kanavin" <alex.kanavin@gmail.com>,
git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: Build race observed with git 2.34.1 - hook-list.h wasn't generated yet
Date: Tue, 7 Dec 2021 09:34:37 -0500 [thread overview]
Message-ID: <0e3e3a4f-f6af-d8df-8973-255ed7b1b7ef@github.com> (raw)
In-Reply-To: <20211207113101.69686-1-alex.kanavin@gmail.com>
Alexander Kanavin wrote:
> Specifically:
>
> builtin/bugreport.c:7:10: fatal error: hook-list.h: No such file or directory
> | 7 | #include "hook-list.h"
> | | ^~~~~~~~~~~~~
> | compilation terminated.
>
> Please see here for the full log:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/59/builds/4427/steps/14/logs/stdio
>
> Seems like COMPUTE_HEADER_DEPENDENCIES isn't working quite right? I meanwhile have set it to
> 'no'.
>
> Thanks,
> Alexander
>
I've encountered this as well, and it appears to be a dependency graph
issue. For me, compilation was fixed by a patch [1] that isn't in next or
master yet ("Needs review" - ab/make-dependency [2]). If this an important
fix to fast-track (I'll defer to more experienced contributors to determine
that), it might speed up review to separate that patch from the rest of the
series?
[1] https://lore.kernel.org/git/patch-v4-19.23-2710f8af6cd-20211117T101807Z-avarab@gmail.com/
[2] https://lore.kernel.org/git/xmqqbl1xqheu.fsf@gitster.g/
next prev parent reply other threads:[~2021-12-07 14:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 11:31 Build race observed with git 2.34.1 - hook-list.h wasn't generated yet Alexander Kanavin
2021-12-07 14:34 ` Victoria Dye [this message]
2021-12-07 17:36 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e3e3a4f-f6af-d8df-8973-255ed7b1b7ef@github.com \
--to=vdye@github.com \
--cc=alex.kanavin@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).