git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dragan Simic <dsimic@manjaro.org>
To: Britton Leo Kerin <britton.kerin@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/1] completion: send-email: don't complete revs when --no-format-patch
Date: Mon, 08 Jan 2024 10:40:56 +0100	[thread overview]
Message-ID: <0e8a1572100faae72db54becefe19f6b@manjaro.org> (raw)
In-Reply-To: <9627364b-c0c9-4b85-a81a-ba1ef0735c9a@smtp-relay.sendinblue.com>

On 2024-01-08 10:36, Britton Leo Kerin wrote:
> Along the way I taught __git_find_last_on_cmdline to understand '--', 
> which
> isn't stricly necessary but I think reads more clearly at the call 
> sites.
> __git_find_on_cmdline could be changed to work the same, or this part 
> dropped
> if people don't like it.

If I may suggest, there's no need for a cover letter for a single patch. 
  If you want to include some notes in the patch submission, which aren't 
supposed to be part of the commit summary, you can do that in the patch 
itself.

> Britton Leo Kerin (1):
>   completion: don't comp revs when --no-format-patch
> 
>  contrib/completion/git-completion.bash | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> 
> base-commit: e79552d19784ee7f4bbce278fe25f93fbda196fa
> --
> 2.43.0

  reply	other threads:[~2024-01-08  9:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-08  9:36 [PATCH 0/1] completion: send-email: don't complete revs when --no-format-patch Britton Leo Kerin
2024-01-08  9:40 ` Dragan Simic [this message]
2024-01-08 19:34   ` Britton Kerin
2024-01-09  1:08 ` [PATCH v2 0/1] completion: " Britton Leo Kerin
     [not found] ` <20240109010830.458775-1-britton.kerin@gmail.com>
2024-01-09  1:08   ` [PATCH v2 1/1] " Britton Leo Kerin
2024-02-07 22:12     ` Junio C Hamano
2024-02-08  7:57     ` Patrick Steinhardt
2024-02-14 20:49       ` Britton Kerin
2024-02-21  1:34         ` Junio C Hamano
2024-03-05 21:58         ` Junio C Hamano
2024-04-28 22:55         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0e8a1572100faae72db54becefe19f6b@manjaro.org \
    --to=dsimic@manjaro.org \
    --cc=britton.kerin@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).