git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j6t@kdbg.org>
To: noloader@gmail.com
Cc: Git List <git@vger.kernel.org>
Subject: Re: Does Git build things during 'make install"?
Date: Mon, 16 Oct 2017 07:58:05 +0200	[thread overview]
Message-ID: <0ec353db-428c-bb6f-03fe-303487fde197@kdbg.org> (raw)
In-Reply-To: <CAH8yC8kx9Td51=UFvLwLAQFPKxUXg0D6KKqWR+JX+-wmTAKYRQ@mail.gmail.com>

Am 16.10.2017 um 07:05 schrieb Jeffrey Walton:
> My script to build Git dies during cleanup. Cleanup removes the
> downloaded tarball and the unpacked directory:
> 
> ********** Cleanup **********
> 
> rm: cannot remove 'git-2.14.2/perl/blib/lib/.exists': Permission denied
> rm: cannot remove 'git-2.14.2/perl/blib/lib/Git/SVN/Fetcher.pm':
> Permission denied
> rm: cannot remove 'git-2.14.2/perl/blib/lib/Git/SVN/Utils.pm': Permission denied
> rm: cannot remove 'git-2.14.2/perl/blib/lib/Git/SVN/Ra.pm': Permission denied
> rm: cannot remove 'git-2.14.2/perl/blib/lib/Git/SVN/GlobSpec.pm':
> Permission denied
> ...
> 
> When I look at the permissions:
> 
> $ ls -Al git-2.14.2/perl/blib/lib/.exists
> -rw-r--r--   1 root     root           0 Oct 16 00:43
> git-2.14.2/perl/blib/lib/.exists
> 
> The only place in my script that does anything with privileges is
> 'make install' because it runs with sudo.
> 
> Is Git building things in the install recipe? If so, then I don't
> believe that's supposed to happen. According to the GNU coding
> standards, Git should not be doing that. Cf;
> https://www.gnu.org/prep/standards/html_node/Standard-Targets.html.

Yes, running "sudo make install" is a nightmare. sudo clears the path, 
and the git command is not found by the make invoked with root 
permissions. This changes the version string that gets compiled into the 
executable, which finally triggers a complete rebuild under root. Sad...

-- Hannes

  reply	other threads:[~2017-10-16  5:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-16  5:05 Does Git build things during 'make install"? Jeffrey Walton
2017-10-16  5:58 ` Johannes Sixt [this message]
2017-10-16  8:23   ` Junio C Hamano
2017-10-16 17:13     ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ec353db-428c-bb6f-03fe-303487fde197@kdbg.org \
    --to=j6t@kdbg.org \
    --cc=git@vger.kernel.org \
    --cc=noloader@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).