From: Thomas Rast <trast@student.ethz.ch>
To: Paul Mackerras <paulus@samba.org>
Cc: "Björn Steinbrink" <B.Steinbrink@gmx.de>, git@vger.kernel.org
Subject: [GITK PATCH] gitk: fix direction of --left-right triangles
Date: Sat, 1 Aug 2009 14:47:47 +0200 [thread overview]
Message-ID: <0fd5fc0f09779bb04c02b54d6ec8f43087a51bca.1249130587.git.trast@student.ethz.ch> (raw)
c961b22 (gitk: Use git log and add support for --left-right,
2007-07-09) introduced --left-right support to gitk, but right from
the start, 'gitk --left-right A...B' oriented the triangles the wrong
way: commits coming from A had a triangle to the right, and vice
versa. To fix this, we simply swap the triangles. (Note that git-log
does it right.)
Noticed-by: Björn Steinbrink <B.Steinbrink@gmx.de>
Signed-off-by: Thomas Rast <trast@student.ethz.ch>
---
Sorry for the double mail, I forgot to Cc the list in the first mail.
gitk | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/gitk b/gitk
index 4604c83..5be2a76 100755
--- a/gitk
+++ b/gitk
@@ -5689,16 +5689,16 @@ proc drawcmittext {id row col} {
} elseif {$listed == 3} {
# triangle pointing left for left-side commits
set t [$canv create polygon \
- [expr {$x - $orad}] $y \
- [expr {$x + $orad - 1}] [expr {$y - $orad}] \
- [expr {$x + $orad - 1}] [expr {$y + $orad - 1}] \
+ [expr {$x + $orad - 1}] $y \
+ [expr {$x - $orad}] [expr {$y - $orad}] \
+ [expr {$x - $orad}] [expr {$y + $orad - 1}] \
-fill $ofill -outline $fgcolor -width 1 -tags circle]
} else {
# triangle pointing right for right-side commits
set t [$canv create polygon \
- [expr {$x + $orad - 1}] $y \
- [expr {$x - $orad}] [expr {$y - $orad}] \
- [expr {$x - $orad}] [expr {$y + $orad - 1}] \
+ [expr {$x - $orad}] $y \
+ [expr {$x + $orad - 1}] [expr {$y - $orad}] \
+ [expr {$x + $orad - 1}] [expr {$y + $orad - 1}] \
-fill $ofill -outline $fgcolor -width 1 -tags circle]
}
set circleitem($row) $t
--
1.6.4.214.gb5b94
next reply other threads:[~2009-08-01 12:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-01 12:47 Thomas Rast [this message]
2009-08-05 21:15 ` [PATCH v2] gitk: fix direction of symmetric difference in optimized mode Thomas Rast
[not found] ` <19066.8802.98042.957009@cargo.ozlabs.ibm.com>
2009-08-06 7:19 ` Thomas Rast
2009-08-08 16:34 ` [RFC PATCH] Simplify away duplicate commits with --cherry-pick --parents Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fd5fc0f09779bb04c02b54d6ec8f43087a51bca.1249130587.git.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=B.Steinbrink@gmx.de \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).