From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Bremner Subject: Re: Commit f5bbc322 to git broke pre-commit hooks which read stdin Date: Tue, 04 Mar 2008 23:15:32 +0100 Message-ID: <0tr6eq87az.wl%bremner@pivot.cs.unb.ca> References: <0tableanpe.wl%bremner@pivot.cs.unb.ca> <7vk5ki91zj.fsf@gitster.siamese.dyndns.org> <0t4pbmaew9.wl%bremner@pivot.cs.unb.ca> Reply-To: David Bremner Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: Junio C Hamano , Kristian =?ISO-8859-15?Q?H=F8gsberg?= , git@vger.kernel.org To: Johannes Schindelin X-From: git-owner@vger.kernel.org Tue Mar 04 23:45:54 2008 Return-path: Envelope-to: gcvg-git-2@gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1JWftJ-0006zQ-1q for gcvg-git-2@gmane.org; Tue, 04 Mar 2008 23:45:45 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933690AbYCDWpG (ORCPT ); Tue, 4 Mar 2008 17:45:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933568AbYCDWpG (ORCPT ); Tue, 4 Mar 2008 17:45:06 -0500 Received: from pivot.cs.unb.ca ([131.202.240.57]:43445 "EHLO pivot.cs.unb.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1765065AbYCDWpE (ORCPT ); Tue, 4 Mar 2008 17:45:04 -0500 X-Greylist: delayed 1765 seconds by postgrey-1.27 at vger.kernel.org; Tue, 04 Mar 2008 17:45:03 EST Received: from bremner by pivot.cs.unb.ca with local (Exim 4.68) (envelope-from ) id 1JWfQ7-00074M-Q2 for git@vger.kernel.org; Tue, 04 Mar 2008 18:15:35 -0400 Received: by pivot.cs.unb.ca (tmda-sendmail, from uid 1266); Tue, 04 Mar 2008 18:15:34 -0400 Received: from bremner (helo=pivot.cs.unb.ca) by pivot.cs.unb.ca with local-esmtp (Exim 4.68) (envelope-from ) id 1JWfQ5-000749-U7; Tue, 04 Mar 2008 18:15:34 -0400 In-Reply-To: User-Agent: SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.7 Emacs/22.1 (i486-pc-linux-gnu) MULE/5.0 (SAKAKI) X-Delivery-Agent: TMDA/1.1.11 (Ladyburn) X-TMDA-Fingerprint: W8xQgW0djot70qOg7NDHsKYJwR8 X-Primary-Address: bremner@unb.ca Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: >>>>> "Johannes" == Johannes Schindelin writes: >> Tue, 4 Mar 2008, David Bremner wrote: >> >> Yeah, I should have been more explicit. The problem is a line >> >> read -N1 VAR Johannes> Can you be even more explicit? IOW why does this have Johannes> to be a pre-commit hook, and cannot be done before Johannes> calling git-commit itself? I have this feeling I don't really understand the question. Yes, in principle, whatever I am doing in a pre-commit hook could be done by hand first. I guess it is primarily a user interface issue. The goal is modify the behaviour of git-commit in a particular repository; isn't this the purpose of pre-commit hooks? All the best, David