From: Luben Tuikov <ltuikov@yahoo.com>
To: git@vger.kernel.org
Subject: Bugs in gitweb
Date: Thu, 4 Jan 2007 17:29:20 -0800 (PST) [thread overview]
Message-ID: <100171.86639.qm@web31814.mail.mud.yahoo.com> (raw)
gitweb has two bugs in git_patchset_body (now you know who
you are without data-mining with git-blame).
The first bug is a missing "</div>" on commitdiff.
Saw this one a couple of days ago, but was swamped
and had no time to post.
The second bug is displaying a renamed file with the
same name as the one of the preceding "patch". Saw
this one today when I pulled.
To exhibit these, you need to "commitdiff" a commit
which has at least one rename and at least one regular
diff preceding the rename.
Can the guilty parties (you know who you are) please
fix this.
"And while at it" can you please actually *do* "refactor"
git_patchset_body *into smaller functions each one doing
a single particular task*.
It is sad to see git_patchset_body in such despicable state
all the while seeing words like "refactor" in the commit logs
of that function.
git_patchset_body is grossly overloaded for what it is
supposed to do to, and being one single huge blob, it is
hard to maintain.
Thanks,
Luben
next reply other threads:[~2007-01-05 1:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-05 1:29 Luben Tuikov [this message]
2007-01-07 1:52 ` [PATCH 0/5] gitweb: git_patchset_body fixes Jakub Narebski
2007-01-08 3:50 ` Luben Tuikov
2007-01-08 9:03 ` Jakub Narebski
2007-01-09 4:25 ` Luben Tuikov
2007-01-09 10:27 ` Jakub Narebski
2007-01-09 16:44 ` Jakub Narebski
2007-01-09 21:38 ` Luben Tuikov
2007-01-09 23:07 ` [PATCH] gitweb: Fix git_patchset_body not closing <div class="patch"> Jakub Narebski
2007-01-09 23:35 ` Luben Tuikov
2007-01-09 20:54 ` [PATCH 0/5] gitweb: git_patchset_body fixes Luben Tuikov
2007-01-07 1:52 ` [PATCH 1/5] gitweb: Fix error in git_patchest_body for file creation/deletion patch Jakub Narebski
2007-01-08 3:53 ` Luben Tuikov
2007-01-07 1:52 ` [PATCH 2/5] gitweb: Fix error in "rename to"/"copy to" git diff header output Jakub Narebski
2007-01-07 1:52 ` [PATCH 3/5] gitweb: Fix errors in git_patchset_body for empty patches Jakub Narebski
2007-01-07 1:52 ` [PATCH 4/5] Revert "gitweb: There can be empty patches (in git_patchset_body)" Jakub Narebski
2007-01-07 1:52 ` [PATCH 5/5] gitweb: Fix split patches output (e.g. file to symlink) Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=100171.86639.qm@web31814.mail.mud.yahoo.com \
--to=ltuikov@yahoo.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).