git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Nov 2024, #07; Wed, 20)
Date: Thu, 21 Nov 2024 16:31:48 +0100	[thread overview]
Message-ID: <10282b43-4b1c-4e8d-a2cd-2aa725622e90@app.fastmail.com> (raw)
In-Reply-To: <xmqq5xogg2to.fsf@gitster.g>

On Thu, Nov 21, 2024, at 13:59, Junio C Hamano wrote:
> "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:
>
>> What should be done about what one might call a
>> trailer topic version for simple topics that might get included in `next` soon
>> after being proposed?
>
> Sorry, but I do not understand what you are asking here.  Can you
> elaborate?

The patch got an Ack from Christian.[1] The patch submitter is supposed to add
trailers like `Acked-by` in subsequent versions according to SubmittingPatches.
But this one went straight from proposal to `next` as far as I could see. And
you’re not supposed to create updates for topics which are in `next` already. Or
at least that’s my impression.

So the question is what to do about such topic updates for adding trailers when
the topic goes into `next` (apparently) straight away? I just let it sit there
for the week in case someone had any counter-proposals for the glossary entry.
So I didn’t post a v2 with the added trailer before the next What’s Cooking.

It’s not important whether the patch/commit might be missing one proposed
trailer. I’m just wondering what to do in cases like this on future topics.

🔗 1: https://lore.kernel.org/git/CAP8UFD3p3ts_7kvk_Zm2efhcPUcEFnLcLFPAqzb40d46BTVzyA@mail.gmail.com/

-- 
Kristoffer Haugsbakk


  reply	other threads:[~2024-11-21 15:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-20  8:49 What's cooking in git.git (Nov 2024, #07; Wed, 20) Junio C Hamano
2024-11-20 10:36 ` Patrick Steinhardt
2024-11-20 13:41   ` shejialuo
2024-11-21  1:10   ` Junio C Hamano
2024-11-20 10:39 ` karthik nayak
2024-11-20 16:40 ` Taylor Blau
2024-11-21  0:44   ` Junio C Hamano
2024-11-22  4:34   ` Junio C Hamano
2024-11-21  8:26 ` Kristoffer Haugsbakk
2024-11-21 12:59   ` Junio C Hamano
2024-11-21 15:31     ` Kristoffer Haugsbakk [this message]
2024-11-21 23:11       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10282b43-4b1c-4e8d-a2cd-2aa725622e90@app.fastmail.com \
    --to=kristofferhaugsbakk@fastmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).