From: "Алексей Шумкин" <zapped@mail.ru>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re[2]: [PATCH] userdiff: match Pascal class methods
Date: Tue, 11 Jan 2011 22:50:59 +0300 [thread overview]
Message-ID: <1093185322.20110111225059@mail.ru> (raw)
In-Reply-To: <7vipxv45ky.fsf@alter.siamese.dyndns.org>
JCH> Alexey Shumkin <zapped@mail.ru> writes:
>> Class declarations were already covered by the second pattern, but class methods have the 'class' keyword in front too. Account for it.
JCH> Too long a line (which I could re-wrap locally but I'd rather not be in
JCH> the business of doing that for everybody).
Ooh, I'm sorry
>> PATTERNS("pascal",
>> - "^((procedure|function|constructor|destructor|interface|"
>> + "^(((class[ \t]+)?(procedure|function)|constructor|destructor|interface|"
>> "implementation|initialization|finalization)[ \t]*.*)$"
JCH> Earlier we took "^procedure frotz", "^function frotz", etc. and now we
JCH> also take "^class procedure frotz", "^class function frotz", but not
JCH> "^class constructor frotz"---am I reading the patterns correctly?
Yes, you're reading correctly. 'class' keyword might precede only
'procedure' or 'function' keyword but not the other ones
prev parent reply other threads:[~2011-01-11 19:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 8:53 [PATCH] userdiff: match Pascal class methods Alexey Shumkin
2011-01-11 19:13 ` Junio C Hamano
2011-01-11 19:50 ` Алексей Шумкин [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1093185322.20110111225059@mail.ru \
--to=zapped@mail.ru \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).