[PATCH] git-imap-send: Allow the program to be run from subdirectories of a git tree.

[PATCH] git-imap-send: Allow the program to be run from subdirectories of a git tree.

[Rob Shearman]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

Call setup_git_directory_gently to allow git-imap-send to be used from
subdirectories of a git tree.

Signed-off-by: Robert Shearman <robertshearman@gmail.com>
---
 imap-send.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 8a59e6e80cd62ce64462486b2b9c9b39053d2777.diff --]
[-- Type: text/x-patch; name=8a59e6e80cd62ce64462486b2b9c9b39053d2777.diff, Size: 324 bytes --]

diff --git a/imap-send.c b/imap-send.c
index 1ec1310..89a1532 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -1296,6 +1296,7 @@ main(int argc, char **argv)
 	/* init the random number generator */
 	arc4_init();
 
+	setup_git_directory_gently( NULL );
 	git_config(git_imap_config, NULL);
 
 	if (!imap_folder) {

Re: [PATCH] git-imap-send: Allow the program to be run from subdirectories of a git tree.

[Miklos Vajna]

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

On Sun, Jun 01, 2008 at 04:28:44PM +0100, Rob Shearman <robertshearman@gmail.com> wrote:
> +	setup_git_directory_gently( NULL );
>  	git_config(git_imap_config, NULL);

I know this is just about cosmetics, but the style of the rest of the
code would suggest using

        setup_git_directory_gently(NULL);

not 

        setup_git_directory_gently( NULL );

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] git-imap-send: Allow the program to be run from subdirectories of a git tree.

[Rob Shearman]

2008/6/1 Miklos Vajna <vmiklos@frugalware.org>:
> On Sun, Jun 01, 2008 at 04:28:44PM +0100, Rob Shearman <robertshearman@gmail.com> wrote:
>> +     setup_git_directory_gently( NULL );
>>       git_config(git_imap_config, NULL);
>
> I know this is just about cosmetics, but the style of the rest of the
> code would suggest using
>
>        setup_git_directory_gently(NULL);
>
> not
>
>        setup_git_directory_gently( NULL );

This isn't my normal coding style - I was trying to match the coding
style to the rest of the file. Only the subsequent line to my added
line uses the "func(arg)" style instead of the "func( arg )" style and
that line was changed to the former very recently.

A patch to fix the style of the call to git_config could be done
separately to this one.

-- 
Rob Shearman

Re: [PATCH] git-imap-send: Allow the program to be run from subdirectories of a git tree.

[Miklos Vajna]

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

On Mon, Jun 02, 2008 at 09:18:09AM +0100, Rob Shearman <robertshearman@gmail.com> wrote:
> > not
> >
> >        setup_git_directory_gently( NULL );
> 
> This isn't my normal coding style - I was trying to match the coding
> style to the rest of the file. Only the subsequent line to my added
> line uses the "func(arg)" style instead of the "func( arg )" style and
> that line was changed to the former very recently.

Ah, I see. I haven't looked at imap-send.c specifically, it seems that
this weird "func( arg )" style is used there a lot of times, so sorry
for bothering you with cosmetics.

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]