Re: [PATCH 3/3] imap-send.c: Clean up coding style to better match the rest of the git codebase.

["Rob Shearman" <robertshearman@gmail.com>]

2008/7/7 Jakub Narebski <jnareb@gmail.com>:
> "Rob Shearman" <robertshearman@gmail.com> writes:
>
>> 2008/7/7 Junio C Hamano <gitster@pobox.com>:
>> > These patches seem to have been linewrapped severely.  I _could_ fix them
>> > up and apply, but the last one being about whitespace and style fixes, I'd
>> > rather not.
>>
>> 2008/6/22 Junio C Hamano <gitster@pobox.com>:
>> > Next time please do _not_ attach *.diff but follow the style of patch
>> > submission other people do (see recent patch from Linus for example).
>>
>> How do you propose I fix this? I attached the patch last time to avoid
>> the problem of line wrapping.
>
> If possible to turn of linewrapping,

It isn't possible AFAIK to turn off linewrapping in Gmail.

> or use either git-send-email
> (I think you can send patches also via Gmail) or git-imap-send,

Ok, but git-imap-send only puts the emails into your Drafts folder so
that you can send them with your normal email client (which is what
does the linewrapping).

For people not familiar with git-imap-send, it has the advantages of
making it possible to automatically add signatures, reply-to headers,
organisation header, etc. already configured in your email client as
well as saving a copy of the email into your "Sent Mail" folder, if
configured.

> then preferred solution is to have patch inline.
>
> If it is not possible, then attach the patch, but preferrably
>  1) with text/plain mimetype (.txt extension instead of .patch or
>    .diff could be required for that)
>
>  2) 8bit (preferred) or quoted-printable (if 8bit is not possible)
>    transfer encoding (base64 is terrible waste of space); text/plain
>    should chose quoted-printable at worst
>
>  3) use "inline" attachement (select 'suggest to display attachement'
>    or something like that), so it is possible to select attachement
>    and hit reply.

I think this was the case with the patches originally sent, but I used
"git format-patch --attach --stdout ... | git imap-send" so if the
mails didn't meet one of those points then it should be fixed in
git-format-patch.

However, I did follow the first suggestion of using "git email-send"
and then I found it didn't work due to a bug, for which I will send a
patch in due course.

-- 
Rob Shearman