git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/4] git-imap-send: Allow the program to be run from subdirectories of a git tree.
@ 2008-07-08 22:18 Robert Shearman
  2008-07-09  1:15 ` Junio C Hamano
  0 siblings, 1 reply; 5+ messages in thread
From: Robert Shearman @ 2008-07-08 22:18 UTC (permalink / raw)
  To: git; +Cc: Robert Shearman

Call setup_git_directory_gently to allow git-imap-send to be used from subdirectories of a git tree.
---
 imap-send.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/imap-send.c b/imap-send.c
index 1ec1310..89a1532 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -1296,6 +1296,7 @@ main(int argc, char **argv)
 	/* init the random number generator */
 	arc4_init();
 
+	setup_git_directory_gently( NULL );
 	git_config(git_imap_config, NULL);
 
 	if (!imap_folder) {
-- 
1.5.6.GIT

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/4] git-imap-send: Allow the program to be run from subdirectories of a git tree.
  2008-07-08 22:18 [PATCH 1/4] git-imap-send: Allow the program to be run from subdirectories of a git tree Robert Shearman
@ 2008-07-09  1:15 ` Junio C Hamano
  2008-07-09  1:28   ` Jay Soffian
  0 siblings, 1 reply; 5+ messages in thread
From: Junio C Hamano @ 2008-07-09  1:15 UTC (permalink / raw)
  To: Robert Shearman; +Cc: git

Robert Shearman <robertshearman@gmail.com> writes:

> Call setup_git_directory_gently to allow git-imap-send to be used from subdirectories of a git tree.
> ---
>  imap-send.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/imap-send.c b/imap-send.c
> index 1ec1310..89a1532 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -1296,6 +1296,7 @@ main(int argc, char **argv)
>  	/* init the random number generator */
>  	arc4_init();
>  
> +	setup_git_directory_gently( NULL );
>  	git_config(git_imap_config, NULL);
>  
>  	if (!imap_folder) {

I thought Jeff already explained why this NULL was a bad idea, but perhaps
I was dreaming...

Besides, the extra spaces around the argument is very distracting.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/4] git-imap-send: Allow the program to be run from subdirectories of a git tree.
  2008-07-09  1:15 ` Junio C Hamano
@ 2008-07-09  1:28   ` Jay Soffian
  2008-07-09 12:08     ` Rob Shearman
  0 siblings, 1 reply; 5+ messages in thread
From: Jay Soffian @ 2008-07-09  1:28 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: Robert Shearman, git

On Tue, Jul 8, 2008 at 9:15 PM, Junio C Hamano <gitster@pobox.com> wrote:
> I thought Jeff already explained why this NULL was a bad idea, but perhaps
> I was dreaming...

http://article.gmane.org/gmane.comp.version-control.git/87701

j.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/4] git-imap-send: Allow the program to be run from subdirectories of a git tree.
  2008-07-09  1:28   ` Jay Soffian
@ 2008-07-09 12:08     ` Rob Shearman
  0 siblings, 0 replies; 5+ messages in thread
From: Rob Shearman @ 2008-07-09 12:08 UTC (permalink / raw)
  To: Jay Soffian; +Cc: Junio C Hamano, git

2008/7/9 Jay Soffian <jaysoffian@gmail.com>:
> On Tue, Jul 8, 2008 at 9:15 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> I thought Jeff already explained why this NULL was a bad idea, but perhaps
>> I was dreaming...
>
> http://article.gmane.org/gmane.comp.version-control.git/87701

Sorry, I missed that message. I'll resend the patch with his suggestion.

-- 
Rob Shearman

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/4] git-imap-send: Allow the program to be run from subdirectories of a git tree.
@ 2008-07-09 21:28 Robert Shearman
  0 siblings, 0 replies; 5+ messages in thread
From: Robert Shearman @ 2008-07-09 21:28 UTC (permalink / raw)
  To: git; +Cc: Robert Shearman

Call setup_git_directory_gently to allow git-imap-send to be used from subdirectories of a git tree.

Signed-off-by: Robert Shearman <robertshearman@gmail.com>
---
 imap-send.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/imap-send.c b/imap-send.c
index 1ec1310..24d76a7 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -1292,10 +1292,12 @@ main(int argc, char **argv)
 	int ofs = 0;
 	int r;
 	int total, n = 0;
+	int nongit_ok;
 
 	/* init the random number generator */
 	arc4_init();
 
+	setup_git_directory_gently(&nongit_ok);
 	git_config(git_imap_config, NULL);
 
 	if (!imap_folder) {
-- 
1.5.6.2.224.g26efb.dirty

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-07-09 21:30 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-08 22:18 [PATCH 1/4] git-imap-send: Allow the program to be run from subdirectories of a git tree Robert Shearman
2008-07-09  1:15 ` Junio C Hamano
2008-07-09  1:28   ` Jay Soffian
2008-07-09 12:08     ` Rob Shearman
  -- strict thread matches above, loose matches on Subject: below --
2008-07-09 21:28 Robert Shearman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).