From: Martin Schlemmer <azarah@nosferatu.za.org>
To: GIT Mailing Lists <git@vger.kernel.org>
Subject: Plug memory leak in update-cache.c
Date: Thu, 14 Apr 2005 10:53:50 +0200 [thread overview]
Message-ID: <1113468830.23299.85.camel@nosferatu.lan> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 641 bytes --]
Hi,
Might not be that an big an issue as it should be freed on exit, but
might cause problems with big trees.
----
Plug memory leak in update-cache.c.
Signed-off-by: Martin Schlemmer <azarah@nosferatu.za.org>
update-cache.c: 22f3ccd47db4f0888901109a8cbf883d272d1cba
--- 22f3ccd47db4f0888901109a8cbf883d272d1cba/update-cache.c
+++ uncommitted/update-cache.c
@@ -202,6 +202,7 @@
printf("%s: needs update\n", ce->name);
continue;
}
+ free(active_cache[i]);
active_cache[i] = new;
}
}
--
Martin Schlemmer
[-- Attachment #1.2: git-plug-leak-in-update_cache.patch --]
[-- Type: text/x-patch, Size: 302 bytes --]
update-cache.c: 22f3ccd47db4f0888901109a8cbf883d272d1cba
--- 22f3ccd47db4f0888901109a8cbf883d272d1cba/update-cache.c
+++ uncommitted/update-cache.c
@@ -202,6 +202,7 @@
printf("%s: needs update\n", ce->name);
continue;
}
+ free(active_cache[i]);
active_cache[i] = new;
}
}
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next reply other threads:[~2005-04-14 8:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-14 8:53 Martin Schlemmer [this message]
2005-04-15 23:48 ` Plug memory leak in update-cache.c Petr Baudis
2005-04-16 0:00 ` Martin Schlemmer
2005-04-16 0:04 ` Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1113468830.23299.85.camel@nosferatu.lan \
--to=azarah@nosferatu.za.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox