From: Pavel Roskin <proski@gnu.org>
To: git <git@vger.kernel.org>
Subject: [PATCH] Makefile uses installed commit-id
Date: Tue, 19 Apr 2005 13:28:38 -0400 [thread overview]
Message-ID: <1113931718.3793.8.camel@dv> (raw)
Hello!
Current git-pasky cannot be compiled properly unless it's already
installed. The rule for creating gitversion.sh requires commit-id in
the PATH, which won't be there until "make install" is run.
Also, commit-id runs gitXnormid.sh, which in turn runs cat-file. All of
them should be from the current directory to avoid the requirement that
git is installed before gitversion.sh is generated.
This patch adds "." to PATH when running commit-id. The patch is
against current git-pasky.
Signed-off-by: Pavel Roskin <proski@gnu.org>
--- a/Makefile
+++ b/Makefile
@@ -46,11 +46,11 @@ $(LIB_FILE): $(LIB_OBJS)
%.o: $(LIB_H)
-gitversion.sh: $(VERSION)
+gitversion.sh: $(VERSION) commit-id
@echo Generating gitversion.sh...
@rm -f $@
@echo "#!/bin/sh" > $@
- @echo "echo \"$(shell cat $(VERSION)) ($(shell commit-id))\"" >> $@
+ @echo "echo \"$(shell cat $(VERSION)) ($(shell PATH=.:$$PATH ./commit-id))\"" >> $@
@chmod +x $@
install: $(PROG) $(GEN_SCRIPT)
--
Regards,
Pavel Roskin
reply other threads:[~2005-04-19 17:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1113931718.3793.8.camel@dv \
--to=proski@gnu.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).