From: Kyle Hayes <kyle@marchex.com>
To: Andy Isaacson <adi@hexapodia.org>
Cc: azarah@nosferatu.za.org, git@vger.kernel.org
Subject: Re: [patch] fixup GECOS handling
Date: Mon, 25 Apr 2005 10:02:17 -0700 [thread overview]
Message-ID: <1114448538.13449.14.camel@axer.marchex.com> (raw)
In-Reply-To: <20050422233012.GA27638@hexapodia.org>
On Fri, 2005-04-22 at 16:30 -0700, Andy Isaacson wrote:
> On Fri, Apr 22, 2005 at 09:16:39AM -0700, Kyle Hayes wrote:
> > if(comma)
> > if(semi)
> > /* lastname, firstname; room #; phone # format */
> > *semi = 0;
> > else
> > *comma = 0;
> > else if(semi)
> > *semi = 0;
>
> That's a really complicated way of writing
>
> if(semi) *semi = 0;
> else if(comma) *comma = 0;
>
> (The two code fragments are precisely identical. Mmmm, strength
> reduction.)
Indeed :-)
As someone else noted, this was too complex. As another person noted,
this (like the SHA1 thread) has been thrashed around more than enough.
Best,
Kyle
--
Kyle Hayes <kyle@marchex.com>
Marchex Inc.
prev parent reply other threads:[~2005-04-25 16:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-18 10:36 [patch] fixup GECOS handling Martin Schlemmer
2005-04-18 12:35 ` David Woodhouse
2005-04-18 12:58 ` Martin Schlemmer
2005-04-22 14:23 ` Martin Schlemmer
2005-04-22 16:16 ` Kyle Hayes
2005-04-22 16:58 ` Martin Schlemmer
2005-04-22 17:18 ` Petr Baudis
2005-04-22 17:25 ` Martin Schlemmer
2005-04-22 17:58 ` Kyle Hayes
2005-04-22 19:06 ` Martin Schlemmer
2005-04-22 20:46 ` Kyle Hayes
2005-04-23 23:38 ` Petr Baudis
2005-04-23 23:49 ` Martin Schlemmer
2005-04-22 17:43 ` Kyle Hayes
2005-04-22 23:30 ` Andy Isaacson
2005-04-25 17:02 ` Kyle Hayes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1114448538.13449.14.camel@axer.marchex.com \
--to=kyle@marchex.com \
--cc=adi@hexapodia.org \
--cc=azarah@nosferatu.za.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).