git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kay Sievers <kay.sievers@vrfy.org>
To: Greg KH <greg@kroah.com>
Cc: Linus Torvalds <torvalds@osdl.org>, git@vger.kernel.org
Subject: Re: [PATCH] fix compare symlink against readlink not data
Date: Fri, 06 May 2005 18:23:34 +0200	[thread overview]
Message-ID: <1115396614.32065.23.camel@localhost.localdomain> (raw)
In-Reply-To: <20050506160359.GB6904@kroah.com>

On Fri, 2005-05-06 at 09:03 -0700, Greg KH wrote:
> On Fri, May 06, 2005 at 03:45:01PM +0200, Kay Sievers wrote:
> > Fix update-cache to compare the blob of a symlink against the link-target
> > and not the file it points to. Also ignore all permissions applied to
> > links.
> > Thanks to Greg for recognizing this while he added our list of symlinks
> > back to the udev repository.
> 
> Hm, even with this patch applied (it's in Linus's tree right now), I
> still get the following with a clean checked out udev tree:
>  $ cg-diff
>  Index: test/sys/block/cciss!c0d0/device
>  ===================================================================

I can't reproduce this. Are you sure, that the git-core binaries are
called and not the cogito ones?

  git-update-cache --refresh
  git-diff-cache -r HEAD
from the core-git should print nothing.

Thanks,
Kay


  reply	other threads:[~2005-05-06 16:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-06 13:45 [PATCH] fix compare symlink against readlink not data Kay Sievers
2005-05-06 16:03 ` Greg KH
2005-05-06 16:23   ` Kay Sievers [this message]
2005-05-06 16:36     ` Greg KH
2005-05-06 16:59       ` Kay Sievers
2005-05-06 17:11       ` Linus Torvalds
2005-05-06 17:19         ` Greg KH
2005-05-06 16:26   ` Junio C Hamano
2005-05-06 16:37     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1115396614.32065.23.camel@localhost.localdomain \
    --to=kay.sievers@vrfy.org \
    --cc=git@vger.kernel.org \
    --cc=greg@kroah.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).