From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcel Holtmann Subject: Re: Commit template Date: Sun, 08 May 2005 22:36:57 +0200 Message-ID: <1115584617.8949.51.camel@pegasus> References: <1965.10.10.10.24.1115579256.squirrel@linux1> <1115579764.8949.15.camel@pegasus> <2003.10.10.10.24.1115580031.squirrel@linux1> <1115580630.8949.27.camel@pegasus> <2095.10.10.10.24.1115582244.squirrel@linux1> <1115582601.8949.31.camel@pegasus> <2159.10.10.10.24.1115582791.squirrel@linux1> <20050508201723.GH9495@pasky.ji.cz> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Sean , GIT Mailing List X-From: git-owner@vger.kernel.org Sun May 08 22:31:58 2005 Return-path: Received: from vger.kernel.org ([12.107.209.244]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DUsQq-0002r6-L6 for gcvg-git@gmane.org; Sun, 08 May 2005 22:31:20 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262957AbVEHUhj (ORCPT ); Sun, 8 May 2005 16:37:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262981AbVEHUha (ORCPT ); Sun, 8 May 2005 16:37:30 -0400 Received: from coyote.holtmann.net ([217.160.111.169]:1966 "EHLO mail.holtmann.net") by vger.kernel.org with ESMTP id S262957AbVEHUgl (ORCPT ); Sun, 8 May 2005 16:36:41 -0400 Received: from pegasus (p5487D02F.dip.t-dialin.net [84.135.208.47]) by mail.holtmann.net (8.12.3/8.12.3/Debian-7.1) with ESMTP id j48KbqWX005421 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Sun, 8 May 2005 22:37:52 +0200 To: Petr Baudis In-Reply-To: <20050508201723.GH9495@pasky.ji.cz> X-Mailer: Evolution 2.2.2 X-Virus-Scanned: ClamAV version 0.83, clamav-milter version 0.83 on coyote.holtmann.net X-Virus-Status: Clean Sender: git-owner@vger.kernel.org Precedence: bulk X-Mailing-List: git@vger.kernel.org Hi Petr, > > > my argument is; not to mess up with the CG: lines created by cg-commit. > > > If you wanna insert a warning then you can of course add additional CG: > > > lines to the commit template. > > > > Well, i'd argue that anyone making their own commit should be responsible > > for making it look however they like. Maybe they want to only use only 60 > > character wide lines and are tired of seeing the notice about CG: being > > ignored. Gives the power user a tad more flexibility. But I really > > don't care much either way. > > I'm with Sean on this one - implemented (with current cg-commit, and I > used .git/commit-template file instead), committed, pushed out. then please do a "touch .git/commit-template" and call cg-commit. Now you will see what I mean. It is too easy to screw up. Why not leave the list of modified files in the hand of the cg-commit and people that wanna extra text inside their commit-template add something like: CG: --- CG: This is my testing tree, don't commit This will look much prettier and gives people the same possibilities to change everything. If you wanna make the modified files list into a full configurable template, then I think you must introduce place holders. Also an option to suppress the list of modified files is possible. Regards Marcel