git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: git@vger.kernel.org
Subject: [PATCH] [RFD] Add repoid identifier to commit
Date: Wed, 11 May 2005 21:38:30 +0000	[thread overview]
Message-ID: <1115847510.22180.108.camel@tglx> (raw)

This is an initial attempt to enable history tracking for multiple
repositories in a consistent state. At the moment this can only be done
by heuristic guessing on the parent dates and the committer names. 
This fails for example with Dave Millers net-2.6 and sparc-2.6 trees, as
in both cases the committer name is the same. It fails also completely
in cases where the system clock of the committer is wrong and the merge
is a head forward. The old bk repository contains entries from 1999 and
2027, which will happen also with git over the time. 

To identify a repository commit-tree tries to read an environment
variable "GIT_REPOSITORY_ID" and has a fallback to the current working
directory. The environment variable keeps the door open for managed
repository id's, but the current working directory is certainly a quite
helpful information to solve the origin decision for history tracking.

Adding a line after the committer should not break any existing tools
AFAICS.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

--- a/commit-tree.c
+++ b/commit-tree.c
@@ -110,6 +110,7 @@ int main(int argc, char **argv)
 	char *gecos, *realgecos, *commitgecos;
 	char *email, *commitemail, realemail[1000];
 	char date[20], realdate[20];
+	char *repoid, repoidbuf[MAXPATHLEN];
 	char *audate;
 	char comment[1000];
 	struct passwd *pw;
@@ -154,6 +155,14 @@ int main(int argc, char **argv)
 	if (audate)
 		parse_date(audate, date, sizeof(date));
 
+	repoid = getenv("GIT_REPOSITORY_ID");
+	if (!repoid)
+		repoid = getcwd(repoidbuf, MAXPATHLEN);
+	else {
+		if (strlen(repoid) == 0)
+			die("GIT_REPOSITORY_ID is empty. Fix it !");
+	}
+
 	remove_special(gecos); remove_special(realgecos); remove_special(commitgecos);
 	remove_special(email); remove_special(realemail); remove_special(commitemail);
 
@@ -170,7 +179,8 @@ int main(int argc, char **argv)
 
 	/* Person/date information */
 	add_buffer(&buffer, &size, "author %s <%s> %s\n", gecos, email, date);
-	add_buffer(&buffer, &size, "committer %s <%s> %s\n\n", commitgecos, commitemail, realdate);
+	add_buffer(&buffer, &size, "committer %s <%s> %s\n", commitgecos, commitemail, realdate);
+	add_buffer(&buffer, &size, "repoid %s\n\n", repoid);
 
 	/* And add the comment */
 	while (fgets(comment, sizeof(comment), stdin) != NULL)



             reply	other threads:[~2005-05-11 21:33 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-11 21:38 Thomas Gleixner [this message]
2005-05-11 22:00 ` [PATCH] [RFD] Add repoid identifier to commit Sean
2005-05-11 22:05   ` Thomas Gleixner
2005-05-11 22:24     ` Sean
2005-05-11 22:30       ` Thomas Gleixner
2005-05-11 22:36         ` Sean
2005-05-11 22:48           ` Thomas Gleixner
2005-05-11 23:01             ` Sean
2005-05-11 23:33               ` Thomas Gleixner
2005-05-11 23:44                 ` Sean
2005-05-12  0:30                   ` Thomas Gleixner
2005-05-12  0:45                     ` Sean
2005-05-12  0:56                       ` Thomas Gleixner
2005-05-12  0:58                         ` Sean
2005-05-12 10:07                           ` David Woodhouse
2005-05-12 10:18                             ` Sean
2005-05-12 10:42                               ` Thomas Gleixner
2005-05-12 10:43                               ` David Woodhouse
2005-05-12 10:58                                 ` Sean
2005-05-12 10:39                             ` Sean
2005-05-11 23:14 ` H. Peter Anvin
2005-05-11 23:38   ` Thomas Gleixner
2005-05-11 23:40     ` H. Peter Anvin
2005-05-11 23:45       ` Sean
2005-05-12  0:04         ` H. Peter Anvin
2005-05-12  0:20           ` Sean
2005-05-12  0:33       ` Thomas Gleixner
2005-05-12  1:46         ` Junio C Hamano
2005-05-12  7:57           ` Thomas Gleixner
2005-05-12  9:32             ` Sean
2005-05-12  9:39               ` Thomas Gleixner
2005-05-12  9:46                 ` Sean
2005-05-12 11:18                   ` Thomas Gleixner
2005-05-12 11:24                     ` Sean
2005-05-12 11:43                       ` Thomas Gleixner
2005-05-12 11:48                         ` Sean
2005-05-12 12:16                           ` Thomas Gleixner
2005-05-12 12:16                             ` Sean
2005-05-12 12:34                               ` Thomas Gleixner
2005-05-12 12:35                                 ` Sean
2005-05-12 12:17                             ` Sean
2005-05-12 12:29                           ` David Woodhouse
2005-05-12 12:32                             ` Sean
2005-05-12 13:29                         ` Jan Harkes
2005-05-12 15:44                           ` Jon Seymour
2005-05-12 15:48                             ` Jon Seymour
2005-05-12 15:50                               ` Jon Seymour
2005-05-12 16:20                                 ` Jan Harkes
2005-05-12 17:09                                   ` Jon Seymour
2005-05-12 17:12                                     ` Jon Seymour
2005-05-12 17:35             ` Junio C Hamano
2005-05-12 18:18               ` Sean
2005-05-12 19:24                 ` Junio C Hamano
2005-05-12 19:35                   ` Sean
2005-05-12 20:47               ` Thomas Gleixner
2005-05-12 21:09                 ` Sean
2005-05-12 21:21                   ` Thomas Gleixner
2005-05-12 21:32                     ` Sean
2005-05-12 21:44                       ` Junio C Hamano
2005-05-12 22:06                       ` Thomas Gleixner
2005-05-12 22:24                         ` Sean
2005-05-12  0:41     ` Dmitry Torokhov
2005-05-12  0:44       ` Thomas Gleixner
2005-05-12  1:09         ` H. Peter Anvin
2005-05-12  1:13           ` H. Peter Anvin
2005-05-12  3:30             ` Joel Becker
2005-05-12  9:17             ` Thomas Gleixner
2005-05-13  1:37   ` [PATCH] [RFD] Add repoid identifier to commit [its a workspace id, isn't it?] Jon Seymour
2005-05-13  8:36     ` Thomas Gleixner
2005-05-13 22:25     ` Petr Baudis
2005-05-13 22:26       ` H. Peter Anvin
2005-05-13 23:39         ` Petr Baudis
2005-05-13 23:49       ` Jon Seymour
2005-05-14  5:02         ` Jon Seymour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1115847510.22180.108.camel@tglx \
    --to=tglx@linutronix.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).