From: Timo Hirvonen <tihirvon@ee.oulu.fi>
To: git@vger.kernel.org
Subject: duplicate htons() in check_file_directory_conflict()
Date: Mon, 06 Jun 2005 23:02:46 +0000 [thread overview]
Message-ID: <1118098966l.5384l.0l@garlic> (raw)
Hi,
create_ce_flags() macro calls htons() so the htons()s in
check_file_directory_conflict() should be removed or alternatively htons
should be removed from the create_ce_flags macro. I noticed the bug when
compiling cogito with -Wshadow.
read-cache.c:208
pos = cache_name_pos(pathbuf,
htons(create_ce_flags(len, stage)));
read-cache.c:232
pos = cache_name_pos(path,
htons(create_ce_flags(namelen, stage)));
--
http://onion.dynserv.net/~timo/
next reply other threads:[~2005-06-06 22:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-06 23:02 Timo Hirvonen [this message]
2005-06-07 1:59 ` duplicate htons() in check_file_directory_conflict() Linus Torvalds
2005-06-07 20:35 ` [PATCH] Use ntohs instead of htons to convert ce_flags to host byte order Timo Hirvonen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1118098966l.5384l.0l@garlic \
--to=tihirvon@ee.oulu.fi \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).