git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: Petr Baudis <pasky@ucw.cz>, git <git@vger.kernel.org>
Subject: [PATCH] cg-admin-cat ignoring -r
Date: Tue, 16 Aug 2005 17:22:59 -0400	[thread overview]
Message-ID: <1124227379.26240.4.camel@dv> (raw)

Hello!

cg-admin-cat ignores the argument for the "-r" option because it uses
optparse incorrectly.  For OPTARG to be set, "-r=" should be used
instead of "-r".

Signed-off-by: Pavel Roskin <proski@gnu.org>

diff --git a/cg-admin-cat b/cg-admin-cat
--- a/cg-admin-cat
+++ b/cg-admin-cat
@@ -27,7 +27,7 @@ USAGE="cg-admin-cat [-r TREE_ID] FILE...
 
 rev=HEAD
 while optparse; do
-	if optparse -r; then
+	if optparse -r=; then
 		rev="$OPTARG"
 	else
 		optfail


-- 
Regards,
Pavel Roskin

                 reply	other threads:[~2005-08-16 21:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1124227379.26240.4.camel@dv \
    --to=proski@gnu.org \
    --cc=git@vger.kernel.org \
    --cc=pasky@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).