From: Pavel Roskin <proski@gnu.org>
To: Petr Baudis <pasky@suse.cz>
Cc: git <git@vger.kernel.org>
Subject: Re: Joining cg-*-id
Date: Mon, 19 Sep 2005 20:19:50 -0400 [thread overview]
Message-ID: <1127175590.31115.10.camel@dv> (raw)
In-Reply-To: <20050919225838.GH18320@pasky.or.cz>
On Tue, 2005-09-20 at 00:58 +0200, Petr Baudis wrote:
> Dear diary, on Tue, Sep 20, 2005 at 12:30:21AM CEST, I got a letter
> where Pavel Roskin <proski@gnu.org> told me that...
> > The value is having one command, one manpage and one place to fix little
> > bugs and add more functionality. Potentially, cg-Xnormid could be
> > incorporated into that script, so bash wouldn't have to open one more
> > file.
>
> Well, cg-Xnormid is basically pointless if it's not going to be a common
> backend for multiple other commands. So I'd say either supersede it with
> git-rev-parse or just merge it with cg-object-id.
Agreed.
> > Please don't apply my patch yet - I forgot to document the optional
> > argument. I'll try to make cg-object-id now.
>
> Which patch?
The one that adds USAGE. Never mind - I see it's fixed already.
As for merging, I see that the existing *-id scripts are a mess. For
instance, cg-parent returns parents separated by spaces, but cg-diff
used "head -1" on its output to get the first parent, i.e it assumes
newline separated output.
Another thing that is broken is "cg-commit-id origin^" - apparently the
"^" parsing is only designed for cg-parent-id.
I think I'll start a local branch for fixing this, and then I'll send
separate patches.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2005-09-20 0:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-19 21:40 Joining cg-*-id Pavel Roskin
2005-09-19 21:56 ` Petr Baudis
2005-09-19 22:16 ` Linus Torvalds
2005-09-19 22:54 ` Petr Baudis
2005-09-20 0:50 ` Linus Torvalds
2005-09-20 13:57 ` Petr Baudis
2005-09-20 14:53 ` Linus Torvalds
2005-09-20 15:07 ` Petr Baudis
2005-09-20 16:54 ` Linus Torvalds
2005-09-20 19:34 ` Linus Torvalds
2005-09-21 10:35 ` Paul Mackerras
2005-09-21 14:51 ` Linus Torvalds
2005-09-21 21:19 ` Paul Mackerras
2005-09-21 8:50 ` Petr Baudis
2005-09-20 15:13 ` Matthias Urlichs
2005-09-20 5:52 ` Junio C Hamano
2005-09-20 10:11 ` Matthias Urlichs
2005-09-20 12:32 ` Paul Mackerras
2005-09-19 22:30 ` Pavel Roskin
2005-09-19 22:58 ` Petr Baudis
2005-09-20 0:19 ` Pavel Roskin [this message]
2005-09-20 0:26 ` Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1127175590.31115.10.camel@dv \
--to=proski@gnu.org \
--cc=git@vger.kernel.org \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).