From: Pavel Roskin <proski@gnu.org>
To: git <git@vger.kernel.org>
Subject: [PATCH] Make logerror() and loginfo() static
Date: Thu, 29 Sep 2005 16:53:14 -0400 [thread overview]
Message-ID: <1128027194.24397.50.camel@dv> (raw)
Make logerror() and loginfo() static
logerror() and loginfo() in daemon.c are never declared and never called
from other files, therefore they should be declared static. Found by
sparse.
Signed-off-by: Pavel Roskin <proski@gnu.org>
diff --git a/daemon.c b/daemon.c
--- a/daemon.c
+++ b/daemon.c
@@ -57,7 +57,7 @@ static void logreport(int priority, cons
write(2, buf, buflen);
}
-void logerror(const char *err, ...)
+static void logerror(const char *err, ...)
{
va_list params;
va_start(params, err);
@@ -65,7 +65,7 @@ void logerror(const char *err, ...)
va_end(params);
}
-void loginfo(const char *err, ...)
+static void loginfo(const char *err, ...)
{
va_list params;
if (!verbose)
--
Regards,
Pavel Roskin
next reply other threads:[~2005-09-29 20:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-29 20:53 Pavel Roskin [this message]
2005-09-30 5:50 ` [PATCH] Make logerror() and loginfo() static Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1128027194.24397.50.camel@dv \
--to=proski@gnu.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).