* [PATCH] Make logerror() and loginfo() static
@ 2005-09-29 20:53 Pavel Roskin
2005-09-30 5:50 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Roskin @ 2005-09-29 20:53 UTC (permalink / raw)
To: git
Make logerror() and loginfo() static
logerror() and loginfo() in daemon.c are never declared and never called
from other files, therefore they should be declared static. Found by
sparse.
Signed-off-by: Pavel Roskin <proski@gnu.org>
diff --git a/daemon.c b/daemon.c
--- a/daemon.c
+++ b/daemon.c
@@ -57,7 +57,7 @@ static void logreport(int priority, cons
write(2, buf, buflen);
}
-void logerror(const char *err, ...)
+static void logerror(const char *err, ...)
{
va_list params;
va_start(params, err);
@@ -65,7 +65,7 @@ void logerror(const char *err, ...)
va_end(params);
}
-void loginfo(const char *err, ...)
+static void loginfo(const char *err, ...)
{
va_list params;
if (!verbose)
--
Regards,
Pavel Roskin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-09-30 5:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-29 20:53 [PATCH] Make logerror() and loginfo() static Pavel Roskin
2005-09-30 5:50 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).