* [PATCH] gitk: use UTF-8 encoding
@ 2005-10-06 2:12 Pavel Roskin
2005-10-06 4:19 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Pavel Roskin @ 2005-10-06 2:12 UTC (permalink / raw)
To: git, Paul Mackerras
gitk should try to use UTF-8 encoding for system operations, such as
reading and writing files and git output.
Signed-off-by: Pavel Roskin <proski@gnu.org>
diff --git a/gitk b/gitk
--- a/gitk
+++ b/gitk
@@ -3726,6 +3726,7 @@ set colors {green red blue magenta darkg
catch {source ~/.gitk}
+catch {encoding system utf-8}
set namefont $mainfont
if {$boldnames} {
lappend namefont bold
--
Regards,
Pavel Roskin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gitk: use UTF-8 encoding
2005-10-06 2:12 [PATCH] gitk: use UTF-8 encoding Pavel Roskin
@ 2005-10-06 4:19 ` Junio C Hamano
2005-10-06 5:00 ` H. Peter Anvin
0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2005-10-06 4:19 UTC (permalink / raw)
To: Pavel Roskin; +Cc: git
Pavel Roskin <proski@gnu.org> writes:
> gitk should try to use UTF-8 encoding for system operations, such as
> reading and writing files and git output.
I agree about commit messages, but I am not so sure about the
file contents (aka user data). Is it possible to control them
separately?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gitk: use UTF-8 encoding
2005-10-06 4:19 ` Junio C Hamano
@ 2005-10-06 5:00 ` H. Peter Anvin
2005-10-06 5:34 ` Pavel Roskin
0 siblings, 1 reply; 4+ messages in thread
From: H. Peter Anvin @ 2005-10-06 5:00 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Pavel Roskin, git
Junio C Hamano wrote:
> Pavel Roskin <proski@gnu.org> writes:
>
>>gitk should try to use UTF-8 encoding for system operations, such as
>>reading and writing files and git output.
>
> I agree about commit messages, but I am not so sure about the
> file contents (aka user data). Is it possible to control them
> separately?
>
git needs to be able to treat user data as arbitrary binary blobs.
However, if interpreting as text, UTF-8 is the right default, at least.
-hpa
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] gitk: use UTF-8 encoding
2005-10-06 5:00 ` H. Peter Anvin
@ 2005-10-06 5:34 ` Pavel Roskin
0 siblings, 0 replies; 4+ messages in thread
From: Pavel Roskin @ 2005-10-06 5:34 UTC (permalink / raw)
To: H. Peter Anvin; +Cc: Junio C Hamano, git
On Wed, 2005-10-05 at 22:00 -0700, H. Peter Anvin wrote:
> Junio C Hamano wrote:
> > Pavel Roskin <proski@gnu.org> writes:
> >
> >>gitk should try to use UTF-8 encoding for system operations, such as
> >>reading and writing files and git output.
> >
> > I agree about commit messages, but I am not so sure about the
> > file contents (aka user data). Is it possible to control them
> > separately?
Yes. "encoding convertfrom" should do the trick. In some projects,
there may be files written in different encodings, such as gettext *.po
files. A patch updating several *.po files would have different parts
in different encodings.
I think gitk could have a submenu in the popup menu with the encodings
to chose from.
> git needs to be able to treat user data as arbitrary binary blobs.
> However, if interpreting as text, UTF-8 is the right default, at least.
I agree.
--
Regards,
Pavel Roskin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-10-06 5:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-10-06 2:12 [PATCH] gitk: use UTF-8 encoding Pavel Roskin
2005-10-06 4:19 ` Junio C Hamano
2005-10-06 5:00 ` H. Peter Anvin
2005-10-06 5:34 ` Pavel Roskin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).