From: Pavel Roskin <proski@gnu.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: gitk shows an empty line between "Comments" and changed files
Date: Thu, 27 Oct 2005 21:36:29 -0400 [thread overview]
Message-ID: <1130463389.2186.14.camel@dv> (raw)
In-Reply-To: <7vslum3l2w.fsf@assigned-by-dhcp.cox.net>
Hi, Junio!
On Thu, 2005-10-27 at 10:51 -0700, Junio C Hamano wrote:
> Pavel Roskin <proski@gnu.org> writes:
>
> > Or maybe the SHA1 header should never be printed at all? It looks like
> > it's not documented anywhere. It doesn't break the tests.
>
> AFAIK, its only user (except humans) is patch-id.
Thank you for reply! git-patch-id is badly documented, and its output
is not documented at all. It outputs two SHA1 hashes, and the second
one is taken from the line produced by git-diff-tree. If there is no
such line, the second ID is 0.
git-patch-id is only used by git-cherry. git-cherry writes the second
SHA1 to some files in a temporary directory, but it never reads those
files, it only checks that they exist.
I'm pretty confident now that the patch I posted in the last message was
correct.
Of course, more cleanup will be needed to remove the second ID from
git-patch-id, to adjust git-cherry accordingly and to remove "p"
assignments in gitk.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2005-10-28 1:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-27 17:30 gitk shows an empty line between "Comments" and changed files Pavel Roskin
2005-10-27 17:51 ` Junio C Hamano
2005-10-28 1:36 ` Pavel Roskin [this message]
2005-10-28 9:13 ` Junio C Hamano
2005-10-28 22:45 ` Pavel Roskin
2005-10-28 23:00 ` Linus Torvalds
2005-10-29 2:49 ` Junio C Hamano
2005-10-29 3:07 ` Linus Torvalds
2005-10-29 4:23 ` Pavel Roskin
2005-10-29 4:33 ` Linus Torvalds
2005-10-29 4:54 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1130463389.2186.14.camel@dv \
--to=proski@gnu.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).