From: Pavel Roskin <proski@gnu.org>
To: git <git@vger.kernel.org>, Petr Baudis <pasky@suse.cz>
Subject: [PATCH] cg-fetch: support for active symbols in rsync path
Date: Fri, 11 Nov 2005 00:49:29 -0500 [thread overview]
Message-ID: <1131688169.31172.34.camel@dv> (raw)
t9112-fetch-rsync.sh breaks if cogito is located in a directory
containing e.g. spaces. The test uses its own rsync replacement
(localrsync) and supplies it to cg-fetch with full patch. cg-fetch
doesn't quote rsync sufficiently to prevent interpreting the path to
localrsync by the shell.
This bug is unlikely to be a problem in real life, but it's important to
have cogito tests run properly in directories with unusual names, since
it allows to catch a number of more serious problems.
Signed-off-by: Pavel Roskin <proski@gnu.org>
diff --git a/cg-fetch b/cg-fetch
index 8fa34ce..6dfd02f 100755
--- a/cg-fetch
+++ b/cg-fetch
@@ -102,7 +102,7 @@ get_rsync()
shift
fi
- eval ${RSYNC:-rsync} $RSYNC_FLAGS $rsync_flags_l -v -Lr \
+ eval '"${RSYNC:-rsync}"' $RSYNC_FLAGS $rsync_flags_l -v -Lr \
"$1$appenduri" "$2$appenduri" $redir | $filter
return ${PIPESTATUS[0]}
}
--
Regards,
Pavel Roskin
reply other threads:[~2005-11-11 5:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1131688169.31172.34.camel@dv \
--to=proski@gnu.org \
--cc=git@vger.kernel.org \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).