* [PATCH] cg-fetch: support for active symbols in rsync path
@ 2005-11-11 5:49 Pavel Roskin
0 siblings, 0 replies; only message in thread
From: Pavel Roskin @ 2005-11-11 5:49 UTC (permalink / raw)
To: git, Petr Baudis
t9112-fetch-rsync.sh breaks if cogito is located in a directory
containing e.g. spaces. The test uses its own rsync replacement
(localrsync) and supplies it to cg-fetch with full patch. cg-fetch
doesn't quote rsync sufficiently to prevent interpreting the path to
localrsync by the shell.
This bug is unlikely to be a problem in real life, but it's important to
have cogito tests run properly in directories with unusual names, since
it allows to catch a number of more serious problems.
Signed-off-by: Pavel Roskin <proski@gnu.org>
diff --git a/cg-fetch b/cg-fetch
index 8fa34ce..6dfd02f 100755
--- a/cg-fetch
+++ b/cg-fetch
@@ -102,7 +102,7 @@ get_rsync()
shift
fi
- eval ${RSYNC:-rsync} $RSYNC_FLAGS $rsync_flags_l -v -Lr \
+ eval '"${RSYNC:-rsync}"' $RSYNC_FLAGS $rsync_flags_l -v -Lr \
"$1$appenduri" "$2$appenduri" $redir | $filter
return ${PIPESTATUS[0]}
}
--
Regards,
Pavel Roskin
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2005-11-11 5:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-11 5:49 [PATCH] cg-fetch: support for active symbols in rsync path Pavel Roskin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).