Git development
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Paul Mackerras <paulus@samba.org>, git@vger.kernel.org
Subject: Re: [PATCH] gitk: UTF-8 support
Date: Mon, 28 Nov 2005 16:55:58 -0500	[thread overview]
Message-ID: <1133214958.27750.8.camel@dv> (raw)
In-Reply-To: <7vr7917hq4.fsf@assigned-by-dhcp.cox.net>

On Sun, 2005-11-27 at 16:12 -0800, Junio C Hamano wrote:
> The following patch on top of your patch has seen only very
> light testing, but it seems to do the right thing for my
> repository with utf-8 commit messages and another with euc-jp
> commit messages.  For the latter, I needed to do:
> 
> 	$ git-repo-config i18n.commitencoding euc-jp

Thank you!  I'm glad my code was actually useful.

Now we may want to make git recode commit data to the repository
encoding.  Lots of iconv/glibc/portability fun on the horizon.  At very
least git should protest if both i18n.commitencoding and the locale
encoding are set to different values.

Another issue is support for non-ASCII characters in the filenames.

-- 
Regards,
Pavel Roskin

      reply	other threads:[~2005-11-28 21:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-23  4:15 [PATCH] gitk: UTF-8 support Pavel Roskin
2005-11-24  0:47 ` Junio C Hamano
2005-11-24  1:11   ` Paul Mackerras
2005-11-24  4:53   ` Pavel Roskin
2005-11-24  6:23     ` Junio C Hamano
2005-11-24  7:12       ` Pavel Roskin
2005-11-28  0:12         ` Junio C Hamano
2005-11-28 21:55           ` Pavel Roskin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1133214958.27750.8.camel@dv \
    --to=proski@gnu.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox