* [PATCH] git-clone --shared should imply --local
@ 2005-11-29 6:20 Pavel Roskin
2005-11-29 7:08 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Pavel Roskin @ 2005-11-29 6:20 UTC (permalink / raw)
To: git
The "--shared" option to git-clone is silently ignored if "--local" is
not specified. The manual doesn't mention such dependency. Make
"--shared" imply "--local".
Signed-off-by: Pavel Roskin <proski@gnu.org>
diff --git a/git-clone.sh b/git-clone.sh
index c09979a..699205e 100755
--- a/git-clone.sh
+++ b/git-clone.sh
@@ -73,7 +73,7 @@ while
*,-n) no_checkout=yes ;;
*,-l|*,--l|*,--lo|*,--loc|*,--loca|*,--local) use_local=yes ;;
*,-s|*,--s|*,--sh|*,--sha|*,--shar|*,--share|*,--shared)
- local_shared=yes ;;
+ local_shared=yes; use_local=yes ;;
*,-q|*,--quiet) quiet=-q ;;
1,-u|1,--upload-pack) usage ;;
*,-u|*,--upload-pack)
--
Regards,
Pavel Roskin
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] git-clone --shared should imply --local
2005-11-29 6:20 [PATCH] git-clone --shared should imply --local Pavel Roskin
@ 2005-11-29 7:08 ` Junio C Hamano
2005-11-29 7:17 ` Pavel Roskin
0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2005-11-29 7:08 UTC (permalink / raw)
To: Pavel Roskin; +Cc: git
Pavel Roskin <proski@gnu.org> writes:
> The "--shared" option to git-clone is silently ignored if "--local" is
> not specified. The manual doesn't mention such dependency. Make
> "--shared" imply "--local".
>
> Signed-off-by: Pavel Roskin <proski@gnu.org>
Hmph, then probably the manual should say it implies it...
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] git-clone --shared should imply --local
2005-11-29 7:08 ` Junio C Hamano
@ 2005-11-29 7:17 ` Pavel Roskin
2005-11-29 7:52 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Pavel Roskin @ 2005-11-29 7:17 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
On Mon, 2005-11-28 at 23:08 -0800, Junio C Hamano wrote:
> Pavel Roskin <proski@gnu.org> writes:
>
> > The "--shared" option to git-clone is silently ignored if "--local" is
> > not specified. The manual doesn't mention such dependency. Make
> > "--shared" imply "--local".
> >
> > Signed-off-by: Pavel Roskin <proski@gnu.org>
>
> Hmph, then probably the manual should say it implies it...
Actually, from the user point of view --local and --shared are
alternatives to each other and to the default behavior. --local copies
files, --shared makes a reference.
Saying that --shared implies --local could sound like git-clone would
still copy all objects.
My description was from the implementation point of view.
--
Regards,
Pavel Roskin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] git-clone --shared should imply --local
2005-11-29 7:17 ` Pavel Roskin
@ 2005-11-29 7:52 ` Junio C Hamano
0 siblings, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2005-11-29 7:52 UTC (permalink / raw)
To: Pavel Roskin; +Cc: git
Pavel Roskin <proski@gnu.org> writes:
> On Mon, 2005-11-28 at 23:08 -0800, Junio C Hamano wrote:
>> Pavel Roskin <proski@gnu.org> writes:
>>
>> > The "--shared" option to git-clone is silently ignored if "--local" is
>> > not specified. The manual doesn't mention such dependency. Make
>> > "--shared" imply "--local".
>> >
>> > Signed-off-by: Pavel Roskin <proski@gnu.org>
>>
>> Hmph, then probably the manual should say it implies it...
>
> Actually, from the user point of view --local and --shared are
> alternatives to each other and to the default behavior. --local copies
> files, --shared makes a reference.
>
> Saying that --shared implies --local could sound like git-clone would
> still copy all objects.
>
> My description was from the implementation point of view.
Ah. Makes sense.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-11-29 7:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-29 6:20 [PATCH] git-clone --shared should imply --local Pavel Roskin
2005-11-29 7:08 ` Junio C Hamano
2005-11-29 7:17 ` Pavel Roskin
2005-11-29 7:52 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).