From: Tommi Virtanen <tv@inoi.fi>
To: git@vger.kernel.org
Cc: Tommi Virtanen <tv@inoi.fi>
Subject: [PATCH] Do not attempt to access literal dirname "GIT_OBJECT_DIRECTORY".
Date: Wed, 30 Nov 2005 17:37:10 +0200 [thread overview]
Message-ID: <11333650304031-git-send-email-tv@inoi.fi> (raw)
In-Reply-To: 1133359173.4117.68.camel@baythorne.infradead.org
Dereference the environment variable before using it.
Signed-off-by: Tommi Virtanen <tv@inoi.fi>
---
setup.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
applies-to: fa10b18d1546129bf73713b64fbc4a8feae3487f
a4a0e60f920f906284f4f6a4d3b4ffb043834bc7
diff --git a/setup.c b/setup.c
index cc44a72..3286a56 100644
--- a/setup.c
+++ b/setup.c
@@ -116,7 +116,7 @@ static const char *setup_git_directory_1
if (validate_symref(path))
goto bad_dir_environ;
if (getenv(DB_ENVIRONMENT)) {
- if (access(DB_ENVIRONMENT, X_OK))
+ if (access(getenv(DB_ENVIRONMENT), X_OK))
goto bad_dir_environ;
}
else {
---
0.99.9.GIT
reply other threads:[~2005-11-30 15:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11333650304031-git-send-email-tv@inoi.fi \
--to=tv@inoi.fi \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox