From: Martin Atukunda <matlads@dsmagic.com>
To: git@vger.kernel.org
Cc: Martin Atukunda <matlads@dsmagic.com>
Subject: [PATCH] [COGITO] make cg-tag use git-check-ref-format
Date: Tue, 13 Dec 2005 13:54:51 +0300 [thread overview]
Message-ID: <11344712912199-git-send-email-matlads@dsmagic.com> (raw)
In-Reply-To: 439C7CA9.4030404@zytor.com
The egrep pattern used by cg-tag is too restrictive. While it will prevent
control characters from being specified as a tag name, it will also reject
nearly anything written in a non-English language, as noted by -hpa
Signed-off-by: Martin Atukunda <matlads@dsmagic.com>
---
cg-tag | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
187670279068e7177149765a7f736cc565a1fe19
diff --git a/cg-tag b/cg-tag
index da4f2d5..73616b8 100755
--- a/cg-tag
+++ b/cg-tag
@@ -54,7 +54,7 @@ id=$(cg-object-id -n "$id") || exit 1
type=$(git-cat-file -t "$id")
id=${id% *}
-(echo $name | egrep -qv '[^a-zA-Z0-9_.@!:-]') || \
+git-check-ref-format $name || \
die "name contains invalid characters"
mkdir -p $_git/refs/tags
--
0.99.9.GIT
next reply other threads:[~2005-12-13 10:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-13 10:54 Martin Atukunda [this message]
2005-12-13 11:13 ` [PATCH] [COGITO] make cg-tag use git-check-ref-format Junio C Hamano
2005-12-13 11:28 ` Martin Atukunda
2005-12-13 17:00 ` Petr Baudis
2005-12-13 18:41 ` Junio C Hamano
2005-12-15 22:24 ` Alex Riesen
2005-12-15 23:38 ` Junio C Hamano
2005-12-16 2:17 ` Junio C Hamano
2005-12-16 9:17 ` Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11344712912199-git-send-email-matlads@dsmagic.com \
--to=matlads@dsmagic.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).