git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: Marco Costalba <mcostalba@gmail.com>
Cc: Linus Torvalds <torvalds@osdl.org>, git <git@vger.kernel.org>,
	Marco Costalba <mcostalba@yahoo.it>
Subject: Re: qgit reports errors in the git repository
Date: Thu, 15 Dec 2005 11:44:55 -0500	[thread overview]
Message-ID: <1134665095.27212.22.camel@dv> (raw)
In-Reply-To: <e5bfff550512150501v48bb65abwf44b3fc21f33bdf6@mail.gmail.com>

Hello, Marco.

On Thu, 2005-12-15 at 14:01 +0100, Marco Costalba wrote:
> Just one quickly note. The error report says:
> git-cat-file 23ea3e201cea0deea909569e08e950a9ec2345f7

It's stderr from git-cat-file.  I guess git-cat-file could be improved.

> the error message should be:
> git-cat-file tag 23ea3e201cea0deea909569e08e950a9ec2345f7
> 
> because it is just the print out of the command line. Or we have 2 bugs ;-)

qgit doesn't print its command line at all when running commands
synchronously.

Signed-off-by: Pavel Roskin <proski@gnu.org>

diff --git a/src/myprocess.cpp b/src/myprocess.cpp
index 5eee6e1..baae026 100644
--- a/src/myprocess.cpp
+++ b/src/myprocess.cpp
@@ -49,6 +49,7 @@ int MyProcess::runAsync(SCRef rc, QObjec
 
 bool MyProcess::runSync(SCRef runCmd, QString* ro) {
 
+	this->runCmd = runCmd;
 	runOutput = ro;
 	if (runOutput != NULL)
 		*runOutput = "";



-- 
Regards,
Pavel Roskin

  parent reply	other threads:[~2005-12-15 16:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-13  0:24 qgit reports errors in the git repository Pavel Roskin
2005-12-13  1:06 ` Linus Torvalds
2005-12-15  5:27   ` Pavel Roskin
     [not found]     ` <e5bfff550512150501v48bb65abwf44b3fc21f33bdf6@mail.gmail.com>
2005-12-15 16:44       ` Pavel Roskin [this message]
     [not found]         ` <e5bfff550512151100k33a66db5tdb2eb1ff2da10a59@mail.gmail.com>
2005-12-16  0:35           ` Pavel Roskin
     [not found]             ` <e5bfff550512152258t3f7b2eb1i1c709572b18fe3f7@mail.gmail.com>
     [not found]               ` <1134757942.2248.11.camel@dv>
     [not found]                 ` <e5bfff550512161247v4c187cc0gedae8234d454c3b6@mail.gmail.com>
2005-12-16 21:37                   ` Junio C Hamano
2005-12-17  6:55                   ` Junio C Hamano
     [not found]                     ` <e5bfff550512170044v59f96262ica6511e981889ea9@mail.gmail.com>
2005-12-17  9:36                       ` Junio C Hamano
2005-12-20  2:11                       ` Pavel Roskin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1134665095.27212.22.camel@dv \
    --to=proski@gnu.org \
    --cc=git@vger.kernel.org \
    --cc=mcostalba@gmail.com \
    --cc=mcostalba@yahoo.it \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).