* [PATCH] gqit: enable compiler warnings
@ 2005-12-21 2:11 Pavel Roskin
2005-12-21 7:11 ` Marco Costalba
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Roskin @ 2005-12-21 2:11 UTC (permalink / raw)
To: Marco Costalba; +Cc: git
The "-O2" flag should be separated from the threading support. Besides,
it belongs to CCFLAGS (compile flags common to C and C++), not to
CPPFLAGS (preprocessor flags). While at that, enable all warnings by
-Wall, except those about non-virtual destructors, which are "inherited"
from Qt. Portability is not affected since -O2 was already
gcc-specific.
Signed-off-by: Pavel Roskin <proski@gnu.org>
diff --git a/SConstruct b/SConstruct
index 55fd206..b0b5d0f 100644
--- a/SConstruct
+++ b/SConstruct
@@ -27,8 +27,10 @@ env['ENV']['HOME'] = os.environ['HOME']
installDir = env['HOME']+'/bin'
+env.Append( CCFLAGS = ['-O2', '-Wall' ,'-Wno-non-virtual-dtor'] )
+
## Uncomment the following if you need threading support threading
-env.Append( CPPFLAGS = ['-O2', '-DQT_THREAD_SUPPORT', '-D_REENTRANT', '-I/usr/include/qt3'] )
+env.Append( CPPFLAGS = ['-DQT_THREAD_SUPPORT', '-D_REENTRANT', '-I/usr/include/qt3'] )
if os.uname()[0] == "FreeBSD":
env.Append(LINKFLAGS=["-pthread"])
--
Regards,
Pavel Roskin
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gqit: enable compiler warnings
2005-12-21 2:11 [PATCH] gqit: enable compiler warnings Pavel Roskin
@ 2005-12-21 7:11 ` Marco Costalba
0 siblings, 0 replies; 2+ messages in thread
From: Marco Costalba @ 2005-12-21 7:11 UTC (permalink / raw)
To: Pavel Roskin; +Cc: Marco Costalba, git
Pavel Roskin wrote:
> The "-O2" flag should be separated from the threading support. Besides,
> it belongs to CCFLAGS (compile flags common to C and C++), not to
> CPPFLAGS (preprocessor flags). While at that, enable all warnings by
> -Wall, except those about non-virtual destructors, which are "inherited"
> from Qt. Portability is not affected since -O2 was already
> gcc-specific.
>
> Signed-off-by: Pavel Roskin <proski@gnu.org>
>
Thanks applied.
___________________________________
Yahoo! Messenger: chiamate gratuite in tutto il mondo
http://it.messenger.yahoo.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-12-21 7:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-12-21 2:11 [PATCH] gqit: enable compiler warnings Pavel Roskin
2005-12-21 7:11 ` Marco Costalba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).