* [PATCH 0/2] Small updates to git-send-email @ 2006-02-02 16:56 Ryan Anderson 2006-02-02 16:56 ` [PATCH 1/2] Provide a more meaningful initial "From " line when using --compose in git-send-email Ryan Anderson 0 siblings, 1 reply; 3+ messages in thread From: Ryan Anderson @ 2006-02-02 16:56 UTC (permalink / raw) To: git These updates fix some usability issues raised by Octavian in #git. Thanks for the feedback! -- Ryan Anderson sometimes Pug Majere ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/2] Provide a more meaningful initial "From " line when using --compose in git-send-email. 2006-02-02 16:56 [PATCH 0/2] Small updates to git-send-email Ryan Anderson @ 2006-02-02 16:56 ` Ryan Anderson 2006-02-02 16:56 ` [PATCH 2/2] git-send-email: Add --quiet to reduce some of the chatter when sending emails Ryan Anderson 0 siblings, 1 reply; 3+ messages in thread From: Ryan Anderson @ 2006-02-02 16:56 UTC (permalink / raw) To: git; +Cc: Ryan Anderson git-send-email, when used with --compose, provided the user with a mbox-format file to edit. Some users, however, were confused by the leading, blank, "From " line, so this change puts the value that will appear on the From: line of the actual email on this line, along with a note that the line is ignored. Signed-off-by: Ryan Anderson <ryan@michonline.com> --- git-send-email.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) c6b0c22e482aa6fe314e4be077d705c98fee7bf2 diff --git a/git-send-email.perl b/git-send-email.perl index ec1428d..51b7513 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -125,7 +125,7 @@ if ($compose) { # effort to have it be unique open(C,">",$compose_filename) or die "Failed to open for writing $compose_filename: $!"; - print C "From \n"; + print C "From $from # This line is ignored.\n"; printf C "Subject: %s\n\n", $initial_subject; printf C <<EOT; GIT: Please enter your email below. -- 1.1.4.g3dcbd ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] git-send-email: Add --quiet to reduce some of the chatter when sending emails. 2006-02-02 16:56 ` [PATCH 1/2] Provide a more meaningful initial "From " line when using --compose in git-send-email Ryan Anderson @ 2006-02-02 16:56 ` Ryan Anderson 0 siblings, 0 replies; 3+ messages in thread From: Ryan Anderson @ 2006-02-02 16:56 UTC (permalink / raw) To: git; +Cc: Ryan Anderson Signed-off-by: Ryan Anderson <ryan@michonline.com> --- git-send-email.perl | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) 3dcbd6298dc6fb4a903404cb9c47e3690bf2e01a diff --git a/git-send-email.perl b/git-send-email.perl index 51b7513..ca1fa37 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -34,7 +34,7 @@ my $compose_filename = ".msg.$$"; my (@to,@cc,$initial_reply_to,$initial_subject,@files,$from,$compose); # Behavior modification variables -my ($chain_reply_to, $smtp_server) = (1, "localhost"); +my ($chain_reply_to, $smtp_server, $quiet) = (1, "localhost", 0); # Example reply to: #$initial_reply_to = ''; #<20050203173208.GA23964@foobar.com>'; @@ -51,6 +51,7 @@ my $rc = GetOptions("from=s" => \$from, "chain-reply-to!" => \$chain_reply_to, "smtp-server=s" => \$smtp_server, "compose" => \$compose, + "quiet" => \$quiet, ); # Now, let's fill any that aren't set in with defaults: @@ -267,8 +268,10 @@ sub send_message sendmail(%mail) or die $Mail::Sendmail::error; - print "OK. Log says:\n", $Mail::Sendmail::log; - print "\n\n" + unless ($quiet) { + print "OK. Log says:\n", $Mail::Sendmail::log; + print "\n\n" + } } -- 1.1.4.g3dcbd ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-02-02 16:56 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2006-02-02 16:56 [PATCH 0/2] Small updates to git-send-email Ryan Anderson 2006-02-02 16:56 ` [PATCH 1/2] Provide a more meaningful initial "From " line when using --compose in git-send-email Ryan Anderson 2006-02-02 16:56 ` [PATCH 2/2] git-send-email: Add --quiet to reduce some of the chatter when sending emails Ryan Anderson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).