From: Pavel Roskin <proski@gnu.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Sam Ravnborg <sam@ravnborg.org>, git@vger.kernel.org
Subject: Re: [PATCH] ls-files: honour per-directory ignore file from higher directories.
Date: Thu, 09 Feb 2006 22:38:50 -0500 [thread overview]
Message-ID: <1139542730.23725.3.camel@dv> (raw)
In-Reply-To: <7vmzh1eykq.fsf_-_@assigned-by-dhcp.cox.net>
Hello, Junio!
On Thu, 2006-02-09 at 00:16 -0800, Junio C Hamano wrote:
> When git-ls-files -o --exclude-per-directory=.gitignore is run
> from a subdirectory, it did not read from .gitignore from its
> parent directory. Reading from them makes output from these two
> commands consistent:
You beat me at that. Thank you!
With this patch, the simplified version of cg-clean passes the cogito
testsuite. That's where the original bug was caught.
> * If there are positive feedbacks on this one, I consider it
> a safe enough candidate to be included in 1.2.0 release.
Yes, it would be nice to see it released.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2006-02-10 3:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-24 17:59 git-ls-files in subdirectories ignore higher-up .gitignore Pavel Roskin
2006-01-25 2:08 ` Junio C Hamano
2006-01-25 6:11 ` Sam Ravnborg
2006-02-09 8:16 ` [PATCH] ls-files: honour per-directory ignore file from higher directories Junio C Hamano
2006-02-10 3:38 ` Pavel Roskin [this message]
2006-02-10 4:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1139542730.23725.3.camel@dv \
--to=proski@gnu.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).