From: "Stephen C. Tweedie" <sct@redhat.com>
To: git mailing list <git@vger.kernel.org>
Cc: Stephen Tweedie <sct@redhat.com>
Subject: Git cannot push to repository with too many tags/heads
Date: Tue, 21 Feb 2006 13:46:07 -0500 [thread overview]
Message-ID: <1140547568.5509.21.camel@orbit.scot.redhat.com> (raw)
Hi,
I'm using git's cvs import to track the Fedora kernel rpm repository,
and it has just passed a watermark that git cannot currently cope with.
The problem is the large number of branches and tags on this repository.
A tag for every build means that the number builds up rapidly, and
git-send-pack has an internal limit of 900 refs to query when building a
pack.
I hoped this wouldn't be a problem. In theory, I should just be able to
push to a single refspec and avoid that limit entirely. But no ---
unfortunately, git is determined to push out the objects for *every* ref
that matches between src and dst when building the pack, even if it's
not actually going to update the remote ref. And in building the
git-rev-list argument list for that colossal update, it exceeds the
internal limit of 900 refs in exec_rev_list().
I think exec_rev_list() is doing the wrong thing here. If I specify an
explicit refspec list for git-send-pack, then when send_pack() calls
match_refs(), we break out to match_explicit_refs() and set
dst->peer_ref only for the ref[s] which match the refspec. send_pack()
then skips all other refs by doing a
if (!ref->peer_ref)
continue;
Unfortunately, exec_rev_list() is missing this, and it tries to ask
git-rev-list for the commit objects of *every* ref on the remote_refs
list, even if they have been explicitly excluded by match_refs() and
have no peer_ref. So with this huge repository, I can't even push a
single refspec without bumping into the limit of 900 refs.
The immediate consequence to me is that I can't push to this particular
repository. But if I'm following the code right, a consequence is that
git-send-pack is accidentally sending all objects for refs that the
remote end is prepared to receive, even if we've supplied a refspec
asking for only a subset of those refs to actually be updated.
I think we can fix this just by adding a test for ref->peer_ref to
exec_rev_list(). That seems to fix the immediate problem for me, at
least. Patch to follow.
--Stephen
next reply other threads:[~2006-02-21 18:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-21 18:46 Stephen C. Tweedie [this message]
2006-02-21 18:48 ` [PATCH] Don't sent objects for refs we're not going to update Stephen C. Tweedie
2006-02-22 1:59 ` Git cannot push to repository with too many tags/heads Junio C Hamano
2006-02-22 2:56 ` Junio C Hamano
2006-02-22 9:51 ` [PATCH] send-pack: do not give up when remote has insanely large number of refs Junio C Hamano
2006-02-22 18:30 ` Stephen C. Tweedie
2006-02-22 18:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1140547568.5509.21.camel@orbit.scot.redhat.com \
--to=sct@redhat.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).