git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Stephen C. Tweedie" <sct@redhat.com>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] send-pack: do not give up when remote has insanely large number of refs.
Date: Wed, 22 Feb 2006 13:30:33 -0500	[thread overview]
Message-ID: <1140633034.3385.5.camel@orbit.scot.redhat.com> (raw)
In-Reply-To: <7v1wxvsovj.fsf_-_@assigned-by-dhcp.cox.net>

Hi,

On Wed, 2006-02-22 at 01:51 -0800, Junio C Hamano wrote:

> +	for (ref = refs, j = i + 16;
> +	     i < 900 && i < j && ref;

Looks like it's now sending just 16 additional negative refs instead of
940 for this repo.  Definitely an improvement --- push (both full and
with an explicit refspec) is now working properly, thanks!  

Adding more ^refs up to the limit of 900 should be possible, too, and
should catch more already-present objects --- while the refs count for
this repo was under 900, push still worked fine for me, so we don't
necessarily have to cut it hard to as low a number as 16.

Perhaps ultimately we may want to simply send the refs list to
git-rev-list via a pipe or similar if we want this to scale?  We'll need
this for edge cases such as sending >900 new tags to an old repository
at once, as we'll exhaust the size of the positive refs list in that
case.

Thanks again,
 Stephen

  reply	other threads:[~2006-02-22 18:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-21 18:46 Git cannot push to repository with too many tags/heads Stephen C. Tweedie
2006-02-21 18:48 ` [PATCH] Don't sent objects for refs we're not going to update Stephen C. Tweedie
2006-02-22  1:59 ` Git cannot push to repository with too many tags/heads Junio C Hamano
2006-02-22  2:56   ` Junio C Hamano
2006-02-22  9:51     ` [PATCH] send-pack: do not give up when remote has insanely large number of refs Junio C Hamano
2006-02-22 18:30       ` Stephen C. Tweedie [this message]
2006-02-22 18:42         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1140633034.3385.5.camel@orbit.scot.redhat.com \
    --to=sct@redhat.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).