git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: junkio@cox.net
Cc: git@vger.kernel.org
Subject: [PATCH 3/9] contrib/git-svn: strip 'git-svn-id:' when commiting to SVN
Date: Fri, 3 Mar 2006 01:20:08 -0800	[thread overview]
Message-ID: <11413776082010-git-send-email-normalperson@yhbt.net> (raw)
In-Reply-To: <114137760733-git-send-email-normalperson@yhbt.net>

We regenerate and use git-svn-id: whenever we fetch or otherwise
commit to remotes/git-svn.  We don't actually know what revision
number we'll commit to SVN at commit time, so this is useless.
It won't throw off things like 'rebuild', though, which knows to
only use the last instance of git-svn-id: in a log message

Signed-off-by: Eric Wong <normalperson@yhbt.net>

---

 contrib/git-svn/git-svn.perl |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

15b28ddfc496fa88cffdfddcc9262cae635a34d0
diff --git a/contrib/git-svn/git-svn.perl b/contrib/git-svn/git-svn.perl
index 67368a5..edae9d4 100755
--- a/contrib/git-svn/git-svn.perl
+++ b/contrib/git-svn/git-svn.perl
@@ -625,6 +625,9 @@ sub svn_commit_tree {
 		while (<$msg_fh>) {
 			if (!$in_msg) {
 				$in_msg = 1 if (/^\s*$/);
+			} elsif (/^git-svn-id: /) {
+				# skip this, we regenerate the correct one
+				# on re-fetch anyways
 			} else {
 				print $msg $_ or croak $!;
 			}
-- 
1.2.3.g4676

  reply	other threads:[~2006-03-03  9:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-03  9:20 contrib/git-svn: polishing up Eric Wong
2006-03-03  9:20 ` [PATCH 1/9] contrib/git-svn: add -b/--branch switch for branch detection Eric Wong
2006-03-03  9:20   ` [PATCH 2/9] contrib/git-svn: several small bug fixes and changes Eric Wong
2006-03-03  9:20     ` Eric Wong [this message]
2006-03-03  9:20       ` [PATCH 4/9] contrib/git-svn: allow --authors-file to be specified Eric Wong
2006-03-03  9:20         ` [PATCH 5/9] contrib/git-svn: cleanup option parsing Eric Wong
2006-03-03  9:20           ` [PATCH 6/9] contrib/git-svn: create a more recent master if one does not exist Eric Wong
2006-03-03  9:20             ` [PATCH 7/9] contrib/git-svn: avoid re-reading the repository uuid, it never changes Eric Wong
2006-03-03  9:20               ` [PATCH 8/9] contrib/git-svn: add --id/-i=$GIT_SVN_ID command-line switch Eric Wong
2006-03-03  9:20                 ` [PATCH 9/9] contrib/git-svn: better documenting of CLI switches Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11413776082010-git-send-email-normalperson@yhbt.net \
    --to=normalperson@yhbt.net \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).