git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Darrin Thompson <darrint@progeny.com>
To: git@vger.kernel.org
Subject: Some Commit Messages Scare git-rev-list
Date: Wed, 12 Apr 2006 09:11:02 -0400	[thread overview]
Message-ID: <1144847462.5213.6.camel@localhost.localdomain> (raw)

This scripts exhibits some odd behavior. Apparently git-rev-list
mishandles commit messages which do not end in a newline. This as best I
can tell this is a problem introduced since 1.1.5.

Here is a script to reproduce the problem:

rm -rf git-test
mkdir git-test
cd git-test
git-init-db
echo hello > hello
git-add hello

# send scary message to git-commit -F -
echo -n "test commit" | git-commit -F - -a
echo world > world
git-add world
git-update-index --add world
treeid=$(git-write-tree)

# send scary message directly to git-commit-tree
commitid=$(echo -n "another-test" | git-commit-tree $treeid -p HEAD)
git-update-ref HEAD $commitid

# see the wreckage
git-rev-list --pretty HEAD

Running gitk will also show the problem.

--
Darrin

             reply	other threads:[~2006-04-12 13:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-12 13:11 Darrin Thompson [this message]
2006-04-12 17:23 ` Some Commit Messages Scare git-rev-list Linus Torvalds
2006-04-12 18:46   ` Junio C Hamano
2006-04-12 19:39     ` Junio C Hamano
2006-04-12 20:04       ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1144847462.5213.6.camel@localhost.localdomain \
    --to=darrint@progeny.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).