git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: git@vger.kernel.org
Subject: git-mailinfo '-u' argument should be default.
Date: Fri, 12 May 2006 17:46:02 +0100	[thread overview]
Message-ID: <1147452362.2794.452.camel@pmac.infradead.org> (raw)

If you apply a patch with 'git-am', it takes the raw content of the
From: header, in whatever character set that happens to be, and puts
that content, untagged, into the commit object. 

That is almost _never_ the right thing to do, surely? Raw data in
untagged character sets is marginally better than line noise.

We should default to the '-u' behaviour, which converts to the character
set which the git repo is stored in. It's not just for converting to
UTF-8, although it looks like it was in the past. Now, however, it
converts to the character set defined in the configuration. So even if
it's a Luddite who for some reason is sticking with an obsolete
character set, it gets that right.

The only option which makes sense _other_ than that would be to just
stick the RFC2047-encoded original From: header into the commit, surely?

-- 
dwmw2

             reply	other threads:[~2006-05-12 16:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-12 16:46 David Woodhouse [this message]
2007-01-09 14:03 ` [PATCH] Re: git-mailinfo '-u' argument should be default David Woodhouse
2007-01-09 14:08   ` Johannes Schindelin
2007-01-09 14:21     ` David Woodhouse
2007-01-09 18:46   ` Junio C Hamano
2007-01-09 23:49     ` David Woodhouse
2007-01-10  0:55       ` Junio C Hamano
2007-01-10  3:24         ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1147452362.2794.452.camel@pmac.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).