git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Wong <normalperson@yhbt.net>
To: Junio C Hamano <junkio@cox.net>, <git@vger.kernel.org>
Cc: Eric Wong <normalperson@yhbt.net>
Subject: [PATCH] send-email: quiet some warnings
Date: Sun, 14 May 2006 19:38:08 -0700	[thread overview]
Message-ID: <11476606883991-git-send-email-normalperson@yhbt.net> (raw)
In-Reply-To: <1147660345772-git-send-email-normalperson@yhbt.net>

Signed-off-by: Eric Wong <normalperson@yhbt.net>

---

 git-send-email.perl |   12 ++++++++++--
 1 files changed, 10 insertions(+), 2 deletions(-)

0e5a33f56f62e527b74b2afbd93a1cca812f97af
diff --git a/git-send-email.perl b/git-send-email.perl
index d27a7a5..379e0c4 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -507,8 +507,16 @@ sub unique_email_list(@) {
 	my @emails;
 
 	foreach my $entry (@_) {
-		my $clean = extract_valid_address($entry);
-		next if $seen{$clean}++;
+		if (my $clean = extract_valid_address($entry)) {
+			$seen{$clean} ||= 0;
+			next if $seen{$clean}++;
+		} else {
+			# it could still be a local email address without '@',
+			# which neither Email::Valid or our own small regex says
+			# is valid...
+			$seen{$entry} ||= 0;
+			next if $seen{$entry}++;
+		}
 		push @emails, $entry;
 	}
 	return @emails;
-- 
1.3.2.g0e5a

  parent reply	other threads:[~2006-05-15  2:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-15  2:32 [PATCH] send-email: allow sendmail binary to be used instead of SMTP Eric Wong
2006-05-15  2:34 ` Eric Wong
2006-05-15  2:38 ` Eric Wong [this message]
2006-05-15  6:04   ` [PATCH] send-email: quiet some warnings Junio C Hamano
2006-05-15  9:41     ` [PATCH] send-email: quiet some warnings, reject invalid addresses Eric Wong
2006-05-15  5:52 ` [PATCH] send-email: allow sendmail binary to be used instead of SMTP Junio C Hamano
2006-05-15  9:27   ` Eric Wong
2006-05-15  9:34     ` Eric Wong
2006-05-15  9:47     ` Junio C Hamano
2006-05-15 10:11       ` Eric Wong
2006-05-15 10:37         ` Martin Langhoff
2006-05-15 16:25           ` Junio C Hamano
2006-05-15 19:10           ` Eric Wong
2006-05-15 21:01       ` Ryan Anderson
2006-05-15 21:13         ` Junio C Hamano
2006-05-15 21:52           ` Ryan Anderson
2006-05-15 22:07           ` Martin Langhoff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11476606883991-git-send-email-normalperson@yhbt.net \
    --to=normalperson@yhbt.net \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).