From: Pavel Roskin <proski@gnu.org>
To: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Off-by-one error in get_path_prefix(), found by Valgrind
Date: Wed, 07 Jun 2006 14:33:24 -0400 [thread overview]
Message-ID: <1149705204.11931.3.camel@dv> (raw)
In-Reply-To: <20060607180543.GA26638@lsrfire.ath.cx>
On Wed, 2006-06-07 at 20:05 +0200, Rene Scharfe wrote:
> Argh, yes. Thanks, Pavel!
Actually, thanks to Julian Seward for Valgrind.
> However, the other branch is incorrect, too:
> accessing path->buf[path->len] is wrong, even if it's within the buffer.
> In order to use a length variable to point to the end of some string we
> need to subtract 1. *sigh* So, how about this one instead?
Fine with me. Thank you for noticing!
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2006-06-07 18:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-07 17:01 [PATCH] Off-by-one error in get_path_prefix(), found by Valgrind Pavel Roskin
2006-06-07 18:05 ` Rene Scharfe
2006-06-07 18:33 ` Pavel Roskin [this message]
2006-06-07 18:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1149705204.11931.3.camel@dv \
--to=proski@gnu.org \
--cc=git@vger.kernel.org \
--cc=rene.scharfe@lsrfire.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).