From: Pavel Roskin <proski@gnu.org>
To: Alexander Litvinov <lan@academsoft.ru>
Cc: Yann Dirson <ydirson@altern.org>, GIT list <git@vger.kernel.org>
Subject: Re: Collecting cvsps patches
Date: Wed, 14 Jun 2006 23:08:32 -0400 [thread overview]
Message-ID: <1150340912.24184.7.camel@dv> (raw)
In-Reply-To: <200606150921.34690.lan@academsoft.ru>
On Thu, 2006-06-15 at 09:21 +0700, Alexander Litvinov wrote:
> Your master branch is not compilable. This is the fix for it.
Actually, revision 5ecebc5064df0fd578dbf4b5ba5255e9af8cda7a renamed
"tagnames" to "link" in cvsps_types.h, so I think the same should be
done in cache.c.
Also, you can check the definition of list_entry, you'll see that the
member (argument 3) is cast to the pointer to the requested type
(argument 2). I don't think it's safe to cast name to a pointer to
TagName.
That said, having non-compilable repository defeats the purpose of
collecting the patches to cvsps. Shouldn't only compilable patches be
allowed in the repository?
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2006-06-15 3:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-11 12:27 Collecting cvsps patches Yann Dirson
[not found] ` <46a038f90606111516v2c8c68e2v818a0a0f9dca2da6@mail.gmail.com>
2006-06-11 22:42 ` Yann Dirson
2006-06-12 11:27 ` Anand Kumria
2006-06-16 21:23 ` Yann Dirson
2006-06-16 21:31 ` Jakub Narebski
2006-06-16 23:22 ` Junio C Hamano
2006-06-17 5:50 ` Junio C Hamano
2006-06-15 2:21 ` Alexander Litvinov
2006-06-15 3:08 ` Pavel Roskin [this message]
2006-06-15 3:14 ` Alexander Litvinov
2006-06-15 16:25 ` Yann Dirson
2006-06-15 7:35 ` Yann Dirson
2006-06-13 4:35 ` Pavel Roskin
2006-06-13 9:54 ` Yann Dirson
2006-06-13 13:46 ` David Mansfield
2006-06-13 15:15 ` Yann Dirson
2006-06-13 15:39 ` Pavel Roskin
2006-06-13 15:47 ` Linus Torvalds
2006-06-16 21:34 ` Yann Dirson
2006-06-13 16:52 ` Jakub Narebski
2006-06-16 21:44 ` What's in cvsps.git Yann Dirson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1150340912.24184.7.camel@dv \
--to=proski@gnu.org \
--cc=git@vger.kernel.org \
--cc=lan@academsoft.ru \
--cc=ydirson@altern.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).