From: Pavel Roskin <proski@gnu.org>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: Keith Packard <keithp@keithp.com>, git <git@vger.kernel.org>
Subject: Re: parsecvs and unnamed branches
Date: Sat, 17 Jun 2006 00:35:50 -0400 [thread overview]
Message-ID: <1150518950.9144.17.camel@dv> (raw)
In-Reply-To: <9e4733910606162115g2165212bgf32a2e328cce751a@mail.gmail.com>
On Sat, 2006-06-17 at 00:15 -0400, Jon Smirl wrote:
> I had already caught that one, the fix was a few mails back.
> git_dir is an atom and shouldn't be freed with free.
I see it now. My patch was wrong - there is another free(git_dir) in
the same function. Keith, please remove both.
> After five hours I hit this:
> fprintf (stderr, "Error: branch cycle\n");
This is more like a logical error. Maybe you actually have circling
branches due to causality violations or something :-)
Sure, Valgrind would be still useful to make sure it's not something
mundane.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2006-06-17 4:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-16 21:44 parsecvs and unnamed branches Jon Smirl
2006-06-16 22:19 ` Keith Packard
2006-06-16 22:28 ` Jon Smirl
2006-06-16 22:39 ` Jon Smirl
2006-06-16 22:51 ` Keith Packard
2006-06-17 3:02 ` Jon Smirl
2006-06-17 3:12 ` Pavel Roskin
2006-06-17 3:31 ` Jon Smirl
2006-06-17 4:08 ` Pavel Roskin
2006-06-17 4:15 ` Jon Smirl
2006-06-17 4:35 ` Pavel Roskin [this message]
2006-06-17 5:30 ` Keith Packard
2006-06-17 5:51 ` Jon Smirl
2006-06-17 17:13 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1150518950.9144.17.camel@dv \
--to=proski@gnu.org \
--cc=git@vger.kernel.org \
--cc=jonsmirl@gmail.com \
--cc=keithp@keithp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).